Browse Source

Convert CMD instructions to exec form for proper signal handling

- Updated 6 Dockerfiles to use JSON array syntax for CMD
- Ensures tail process runs as PID 1 and receives signals properly
- Improves container shutdown behavior and signal forwarding

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
fix-flaky-tests-and-dockerfile
Tim Kimber 5 months ago
parent
commit
7542bc598c
6 changed files with 6 additions and 6 deletions
  1. +1
    -1
      test/Dockerfile-bash4-0
  2. +1
    -1
      test/Dockerfile-bash4-2
  3. +1
    -1
      test/Dockerfile-bash5-0
  4. +1
    -1
      test/Dockerfile-centos7-dynu
  5. +1
    -1
      test/Dockerfile-ubuntu-acmedns
  6. +1
    -1
      test/Dockerfile-ubuntu-dynu

+ 1
- 1
test/Dockerfile-bash4-0 View File

@ -31,4 +31,4 @@ RUN /bats-core/install.sh /usr/local
# Use supervisord to run nginx in the background
COPY ./test/test-config/alpine-supervisord.conf /etc/supervisord.conf
CMD tail -f /dev/null
CMD [ "tail", "-f", "/dev/null" ]

+ 1
- 1
test/Dockerfile-bash4-2 View File

@ -31,4 +31,4 @@ RUN /bats-core/install.sh /usr/local
# Use supervisord to run nginx in the background
COPY ./test/test-config/alpine-supervisord.conf /etc/supervisord.conf
CMD tail -f /dev/null
CMD [ "tail", "-f", "/dev/null" ]

+ 1
- 1
test/Dockerfile-bash5-0 View File

@ -31,4 +31,4 @@ RUN /bats-core/install.sh /usr/local
# Use supervisord to run nginx in the background
COPY ./test/test-config/alpine-supervisord.conf /etc/supervisord.conf
CMD tail -f /dev/null
CMD [ "tail", "-f", "/dev/null" ]

+ 1
- 1
test/Dockerfile-centos7-dynu View File

@ -30,4 +30,4 @@ RUN /bats-core/install.sh /usr/local
EXPOSE 80 443
# Run eternal loop - for testing
CMD tail -f /dev/null
CMD [ "tail", "-f", "/dev/null" ]

+ 1
- 1
test/Dockerfile-ubuntu-acmedns View File

@ -36,4 +36,4 @@ RUN git clone https://github.com/bats-core/bats-assert /bats-assert
RUN /bats-core/install.sh /usr/local
# Run eternal loop - for testing
CMD tail -f /dev/null
CMD [ "tail", "-f", "/dev/null" ]

+ 1
- 1
test/Dockerfile-ubuntu-dynu View File

@ -33,4 +33,4 @@ RUN git clone https://github.com/bats-core/bats-assert /bats-assert
RUN /bats-core/install.sh /usr/local
# Run eternal loop - for testing
CMD tail -f /dev/null
CMD [ "tail", "-f", "/dev/null" ]

Loading…
Cancel
Save