diff --git a/getssl b/getssl index 30d8837..574f7bc 100755 --- a/getssl +++ b/getssl @@ -598,6 +598,8 @@ check_challenge_completion_dns() { # perform validation via DNS challenge rr_cname=$(grep -i "^${rr}"<<<"${check_output}"|grep 'IN\WCNAME'|awk '{ print $5}') debug "cname check=\"$rr_cname\"" if [[ -n "$rr_cname" ]]; then + # shellcheck disable=SC2086 + check_output=$($DNS_CHECK_FUNC $DNS_CHECK_OPTIONS TXT "${rr_cname}" "@${ns}") check_result=$(grep -i "^${rr_cname}"<<<"${check_output}"|grep 'IN\WTXT'|awk -F'"' '{ print $2}' | uniq) fi fi @@ -1216,7 +1218,7 @@ create_order() { dn=0 for d in "${alldomains[@]}"; do # get authorizations link - AuthLink[$dn]=$(json_get "$response" "identifiers" "value" "${d##\*.}" "authorizations" "x") + AuthLink[dn]=$(json_get "$response" "identifiers" "value" "${d##\*.}" "authorizations" "x") debug "authorizations link for $d - ${AuthLink[$dn]}" ((dn++)) done @@ -1240,8 +1242,8 @@ create_order() { if [[ ( "$lower_d" == "$authdomain" && -z "$wildcard" ) || ( "$lower_d" == "*.${authdomain}" && -n "$wildcard" ) ]]; then debug "Saving authorization response for $authdomain for domain alldomains[$dn]" debug "Response = ${response//[$'\t\r\n']}" - AuthLinkResponse[$dn]=$response - AuthLinkResponseHeader[$dn]=$responseHeaders + AuthLinkResponse[dn]=$response + AuthLinkResponseHeader[dn]=$responseHeaders fi ((dn++)) done diff --git a/test/README-Testing.md b/test/README-Testing.md index 5d67977..9936541 100644 --- a/test/README-Testing.md +++ b/test/README-Testing.md @@ -30,20 +30,20 @@ For individual accounts, is your github account name. ## To run all the tests on a single OS 1. Start `pebble` and `challtestsrv` using ```docker-compose up -d --build``` -2. Run the test suite ```run-test.sh []``` -3. eg. `run-test.sh ubuntu16` +2. Run the test suite ```test/run-test.sh []``` +3. eg. `test/run-test.sh ubuntu16` ## To run a single bats test on a single OS 1. Start `pebble` and `challtestsrv` using ```docker-compose up -d --build``` -2. ```run-test.sh bats ``` -3. e.g. `run-test.sh ubuntu bats /getssl/test/1-simple-http01.bats` +2. ```test/run-test.sh bats ``` +3. e.g. `test/run-test.sh ubuntu bats /getssl/test/1-simple-http01.bats` ## To debug a test 1. Start `pebble` and `challtestsrv` using ```docker-compose up -d --build``` 2. ```run-test.sh /getssl/test/debug-test.sh ``` -3. e.g. `run-test.sh ubuntu /getssl/test/debug-test.sh -d /getssl/test/test-config/getssl-http01-cfg` +3. e.g. `test/run-test.sh ubuntu /getssl/test/debug-test.sh -d /getssl/test/test-config/getssl-http01-cfg` ## TODO