From a83240400cfe4ce5f90dd71b2ba0c0f20a79b1db Mon Sep 17 00:00:00 2001
From: Timothe Litt <litt@acm.org>
Date: Wed, 25 Aug 2021 15:36:29 -0400
Subject: [PATCH] Use GitHub secrets for dynamic dns test credentials

Note: To add the secrets to your repository on GitHub

Goto Actions -> Settings -> Secrets

New Repository Secret

Add DUCKDNS_TOKEN
Add DYNU_API_KEY
---
 .github/workflows/run-tests-staging-duckdns.yml | 2 ++
 .github/workflows/run-tests-staging-dynu.yml    | 2 ++
 test/Dockerfile-centos7-duckdns                 | 2 +-
 test/Dockerfile-centos7-dynu                    | 2 +-
 test/Dockerfile-ubuntu-duckdns                  | 2 +-
 test/Dockerfile-ubuntu-dynu                     | 2 +-
 test/run-test.sh                                | 2 ++
 7 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/run-tests-staging-duckdns.yml b/.github/workflows/run-tests-staging-duckdns.yml
index a6348bc..7647afe 100644
--- a/.github/workflows/run-tests-staging-duckdns.yml
+++ b/.github/workflows/run-tests-staging-duckdns.yml
@@ -8,6 +8,8 @@ on:
   pull_request:
     branches:
       - master
+env:
+  DUCKDNS_TOKEN: ${{ secrets.DUCKDNS_TOKEN }}
 jobs:
   test-centos7-duckdns:
     runs-on: ubuntu-latest
diff --git a/.github/workflows/run-tests-staging-dynu.yml b/.github/workflows/run-tests-staging-dynu.yml
index 1f55bae..294faf5 100644
--- a/.github/workflows/run-tests-staging-dynu.yml
+++ b/.github/workflows/run-tests-staging-dynu.yml
@@ -8,6 +8,8 @@ on:
   pull_request:
     branches:
       - master
+env:
+  DYNU_API_KEY: ${{ secrets.DYNU_API_KEY }}
 jobs:
   test-centos7-dynu:
     runs-on: ubuntu-latest
diff --git a/test/Dockerfile-centos7-duckdns b/test/Dockerfile-centos7-duckdns
index be26c79..96a5fab 100644
--- a/test/Dockerfile-centos7-duckdns
+++ b/test/Dockerfile-centos7-duckdns
@@ -14,7 +14,7 @@ ENV LC_ALL en_US.UTF-8
 
 ENV staging "true"
 ENV dynamic_dns "dynu"
-ENV DUCKDNS_TOKEN 1d616aa9-b8e4-4bb4-b312-3289de82badb
+#ENV DUCKDNS_TOKEN 
 
 WORKDIR /root
 RUN mkdir -p /etc/nginx/pki/private
diff --git a/test/Dockerfile-centos7-dynu b/test/Dockerfile-centos7-dynu
index 65c8051..09a1534 100644
--- a/test/Dockerfile-centos7-dynu
+++ b/test/Dockerfile-centos7-dynu
@@ -14,7 +14,7 @@ ENV LC_ALL en_US.UTF-8
 
 ENV staging "true"
 ENV dynamic_dns "duckdns"
-ENV DYNU_API_KEY 65cXefd35XbYf36546eg5dYcZT6X52Y2
+#ENV DYNU_API_KEY 
 
 WORKDIR /root
 RUN mkdir /etc/nginx/pki
diff --git a/test/Dockerfile-ubuntu-duckdns b/test/Dockerfile-ubuntu-duckdns
index f0f2edd..c4fdc6a 100644
--- a/test/Dockerfile-ubuntu-duckdns
+++ b/test/Dockerfile-ubuntu-duckdns
@@ -8,7 +8,7 @@ ENV DEBIAN_FRONTEND noninteractive
 # Ensure tests in this image use the staging server
 ENV staging "true"
 ENV dynamic_dns "duckdns"
-ENV DUCKDNS_TOKEN 1d616aa9-b8e4-4bb4-b312-3289de82badb
+#ENV DUCKDNS_TOKEN 
 
 # Update and install required software
 RUN apt-get update --fix-missing
diff --git a/test/Dockerfile-ubuntu-dynu b/test/Dockerfile-ubuntu-dynu
index b010293..68f5c06 100644
--- a/test/Dockerfile-ubuntu-dynu
+++ b/test/Dockerfile-ubuntu-dynu
@@ -8,7 +8,7 @@ ENV DEBIAN_FRONTEND noninteractive
 # Ensure tests in this image use the staging server
 ENV staging "true"
 ENV dynamic_dns "dynu"
-ENV DYNU_API_KEY 65cXefd35XbYf36546eg5dYcZT6X52Y2
+#ENV DYNU_API_KEY 
 
 # Update and install required software
 RUN apt-get update --fix-missing
diff --git a/test/run-test.sh b/test/run-test.sh
index 76a7555..d6156fb 100755
--- a/test/run-test.sh
+++ b/test/run-test.sh
@@ -38,6 +38,8 @@ docker run \
   --env GETSSL_IDN_HOST=$GETSSL_IDN_HOST \
   --env GETSSL_OS=$GETSSL_OS \
   --env GITHUB_REPOSITORY="${GITHUB_REPOSITORY}" \
+  --env DUCKDNS_TOKEN="${DUCKDNS_TOKEN}" \
+  --env DYNU_API_KEY="${DYNU_API_KEY}" \
   -v "$(pwd)":/getssl \
   --rm \
   --network ${PWD##*/}_acmenet \