From fb7b3ee145203257ee59c6a81fb1a9995f29084c Mon Sep 17 00:00:00 2001
From: Peter Dave Hello <hsu@peterdavehello.org>
Date: Thu, 26 Nov 2020 20:08:44 +0800
Subject: [PATCH] Use JSON notation for Dockerfile CMD arguments
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Reference:
- https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#cmd

> The `CMD` instruction should be used to run the software contained in
your image, along with any arguments. `CMD` should almost always be used
in the form of `CMD ["executable", "param1", "param2"…]`
---
 test/Dockerfile-alpine          | 2 +-
 test/Dockerfile-centos6         | 2 +-
 test/Dockerfile-centos7-staging | 2 +-
 test/Dockerfile-debian          | 2 +-
 test/Dockerfile-ubuntu          | 2 +-
 test/Dockerfile-ubuntu-staging  | 2 +-
 test/Dockerfile-ubuntu16        | 2 +-
 test/Dockerfile-ubuntu18        | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/test/Dockerfile-alpine b/test/Dockerfile-alpine
index 5b1dbf3..399e10f 100644
--- a/test/Dockerfile-alpine
+++ b/test/Dockerfile-alpine
@@ -18,4 +18,4 @@ RUN /bats-core/install.sh /usr/local
 
 # Use supervisord to run nginx in the background
 COPY ./test/test-config/alpine-supervisord.conf /etc/supervisord.conf
-CMD tail -f /dev/null
+CMD [ "tail", "-f", "/dev/null" ]
diff --git a/test/Dockerfile-centos6 b/test/Dockerfile-centos6
index 108add0..66cc468 100644
--- a/test/Dockerfile-centos6
+++ b/test/Dockerfile-centos6
@@ -23,4 +23,4 @@ RUN /bats-core/install.sh /usr/local
 EXPOSE 80 443
 
 # Run eternal loop - for testing
-CMD tail -f /dev/null
+CMD [ "tail", "-f", "/dev/null" ]
diff --git a/test/Dockerfile-centos7-staging b/test/Dockerfile-centos7-staging
index abb697c..f3d985b 100644
--- a/test/Dockerfile-centos7-staging
+++ b/test/Dockerfile-centos7-staging
@@ -24,4 +24,4 @@ RUN /bats-core/install.sh /usr/local
 EXPOSE 80 443
 
 # Run eternal loop - for testing
-CMD tail -f /dev/null
+CMD [ "tail", "-f", "/dev/null" ]
diff --git a/test/Dockerfile-debian b/test/Dockerfile-debian
index 6da08d5..640f069 100644
--- a/test/Dockerfile-debian
+++ b/test/Dockerfile-debian
@@ -16,4 +16,4 @@ RUN git clone --depth 1 https://github.com/bats-core/bats-assert /bats-assert
 RUN /bats-core/install.sh /usr/local
 
 # Run eternal loop - for testing
-CMD tail -f /dev/null
+CMD [ "tail", "-f", "/dev/null" ]
diff --git a/test/Dockerfile-ubuntu b/test/Dockerfile-ubuntu
index 21169ea..953c3bf 100644
--- a/test/Dockerfile-ubuntu
+++ b/test/Dockerfile-ubuntu
@@ -22,4 +22,4 @@ RUN git clone --depth 1 https://github.com/bats-core/bats-assert /bats-assert
 RUN /bats-core/install.sh /usr/local
 
 # Run eternal loop - for testing
-CMD tail -f /dev/null
+CMD [ "tail", "-f", "/dev/null" ]
diff --git a/test/Dockerfile-ubuntu-staging b/test/Dockerfile-ubuntu-staging
index 15d5a59..8fc3455 100644
--- a/test/Dockerfile-ubuntu-staging
+++ b/test/Dockerfile-ubuntu-staging
@@ -26,4 +26,4 @@ RUN git clone --depth 1 https://github.com/bats-core/bats-assert /bats-assert
 RUN /bats-core/install.sh /usr/local
 
 # Run eternal loop - for testing
-CMD tail -f /dev/null
+CMD [ "tail", "-f", "/dev/null" ]
diff --git a/test/Dockerfile-ubuntu16 b/test/Dockerfile-ubuntu16
index 6b13f68..bb521ff 100644
--- a/test/Dockerfile-ubuntu16
+++ b/test/Dockerfile-ubuntu16
@@ -18,4 +18,4 @@ RUN git clone --depth 1 https://github.com/bats-core/bats-assert /bats-assert
 RUN /bats-core/install.sh /usr/local
 
 # Run eternal loop - for testing
-CMD tail -f /dev/null
+CMD [ "tail", "-f", "/dev/null" ]
diff --git a/test/Dockerfile-ubuntu18 b/test/Dockerfile-ubuntu18
index 0979cab..98b71af 100644
--- a/test/Dockerfile-ubuntu18
+++ b/test/Dockerfile-ubuntu18
@@ -23,4 +23,4 @@ RUN /bats-core/install.sh /usr/local
 EXPOSE 80 443
 
 # Run eternal loop - for testing
-CMD tail -f /dev/null
+CMD [ "tail", "-f", "/dev/null" ]