From 6a1168967f1e3a678a23566b75599dbbc538c25b Mon Sep 17 00:00:00 2001 From: Dmitry Date: Sun, 24 Jul 2022 20:08:50 +0300 Subject: [PATCH 1/2] Add handle errors on channel closing while reconnecting. --- channel.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/channel.go b/channel.go index 62122ea..135d68e 100644 --- a/channel.go +++ b/channel.go @@ -103,8 +103,14 @@ func (chManager *channelManager) reconnect() error { return err } - chManager.channel.Close() - chManager.connection.Close() + err = chManager.channel.Close() + if err != nil { + return err + } + err = chManager.connection.Close() + if err != nil { + return err + } chManager.connection = newConn chManager.channel = newChannel From 4e82d8db5b02e776ac7764fb8dbbd6fdeca3af37 Mon Sep 17 00:00:00 2001 From: Dmitry Date: Mon, 3 Oct 2022 11:24:53 +0500 Subject: [PATCH 2/2] Change error forwarding to logging. --- channel.go | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/channel.go b/channel.go index 135d68e..e1226db 100644 --- a/channel.go +++ b/channel.go @@ -103,13 +103,12 @@ func (chManager *channelManager) reconnect() error { return err } - err = chManager.channel.Close() - if err != nil { - return err + if err = chManager.channel.Close(); err != nil { + chManager.logger.Warnf("error closing channel while reconnecting: %v", err) } - err = chManager.connection.Close() - if err != nil { - return err + + if err = chManager.connection.Close(); err != nil { + chManager.logger.Warnf("error closing connection while reconnecting: %v", err) } chManager.connection = newConn