From 02fe055035d28d046ff132b39262abdb923ca3e5 Mon Sep 17 00:00:00 2001 From: sopwithcamel Date: Tue, 21 Nov 2023 14:13:06 +0530 Subject: [PATCH] Avoid unnecessary copies of PhoneMetadata The PhoneMetadata can be moved into the hashmap avoiding a copy. --- cpp/src/phonenumbers/shortnumberinfo.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cpp/src/phonenumbers/shortnumberinfo.cc b/cpp/src/phonenumbers/shortnumberinfo.cc index 8e5d12df9..f7fd1513f 100644 --- a/cpp/src/phonenumbers/shortnumberinfo.cc +++ b/cpp/src/phonenumbers/shortnumberinfo.cc @@ -52,9 +52,9 @@ ShortNumberInfo::ShortNumberInfo() LOG(DFATAL) << "Could not parse compiled-in metadata."; return; } - for (const auto& metadata : metadata_collection.metadata()) { - const string& region_code = metadata.id(); - region_to_short_metadata_map_->insert(std::make_pair(region_code, metadata)); + for (auto& metadata : *(metadata_collection.mutable_metadata())) { + const string region_code = metadata.id(); + region_to_short_metadata_map_->emplace(region_code, std::move(metadata)); } regions_where_emergency_numbers_must_be_exact_->insert("BR"); regions_where_emergency_numbers_must_be_exact_->insert("CL");