From 03e2a0b314e2e7f0d79deb11895db856fd5408e1 Mon Sep 17 00:00:00 2001 From: penmetsaa Date: Wed, 3 Oct 2018 16:31:44 +0530 Subject: [PATCH] Update ShortNumberInfo test regarding example number change. (#2268) * Update ShortNumberInfo test regarding example number change for region AM. Unlike PhoneNumberUtilTest, ShortNumberInfoTest uses real metadata for unit testing. * Changing the region as Travis tests do not pass with old short metadata of AM * Making same changes in CPP and JS --- cpp/test/phonenumbers/shortnumberinfo_test.cc | 2 +- .../test/com/google/i18n/phonenumbers/ShortNumberInfoTest.java | 2 +- javascript/i18n/phonenumbers/shortnumberinfo_test.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cpp/test/phonenumbers/shortnumberinfo_test.cc b/cpp/test/phonenumbers/shortnumberinfo_test.cc index 145cd9d19..0f70eb9f3 100644 --- a/cpp/test/phonenumbers/shortnumberinfo_test.cc +++ b/cpp/test/phonenumbers/shortnumberinfo_test.cc @@ -299,7 +299,7 @@ TEST_F(ShortNumberInfoTest, GetExpectedCostForSharedCountryCallingCode) { } TEST_F(ShortNumberInfoTest, GetExampleShortNumber) { - EXPECT_EQ("8711", short_info_.GetExampleShortNumber(RegionCode::AM())); + EXPECT_EQ("110", short_info_.GetExampleShortNumber(RegionCode::AD())); EXPECT_EQ("1010", short_info_.GetExampleShortNumber(RegionCode::FR())); EXPECT_EQ("", short_info_.GetExampleShortNumber(RegionCode::UN001())); EXPECT_EQ("", short_info_.GetExampleShortNumber(RegionCode::GetUnknown())); diff --git a/java/libphonenumber/test/com/google/i18n/phonenumbers/ShortNumberInfoTest.java b/java/libphonenumber/test/com/google/i18n/phonenumbers/ShortNumberInfoTest.java index 05865cd21..f76c6842b 100644 --- a/java/libphonenumber/test/com/google/i18n/phonenumbers/ShortNumberInfoTest.java +++ b/java/libphonenumber/test/com/google/i18n/phonenumbers/ShortNumberInfoTest.java @@ -195,7 +195,7 @@ public class ShortNumberInfoTest extends TestMetadataTestCase { } public void testGetExampleShortNumber() { - assertEquals("8711", shortInfo.getExampleShortNumber(RegionCode.AM)); + assertEquals("110", shortInfo.getExampleShortNumber(RegionCode.AD)); assertEquals("1010", shortInfo.getExampleShortNumber(RegionCode.FR)); assertEquals("", shortInfo.getExampleShortNumber(RegionCode.UN001)); assertEquals("", shortInfo.getExampleShortNumber(null)); diff --git a/javascript/i18n/phonenumbers/shortnumberinfo_test.js b/javascript/i18n/phonenumbers/shortnumberinfo_test.js index e2c0380c4..146b5a982 100644 --- a/javascript/i18n/phonenumbers/shortnumberinfo_test.js +++ b/javascript/i18n/phonenumbers/shortnumberinfo_test.js @@ -271,7 +271,7 @@ function testGetExpectedCostForSharedCountryCallingCode() { } function testGetExampleShortNumber() { - assertEquals('8711', shortInfo.getExampleShortNumber(RegionCode.AM)); + assertEquals('110', shortInfo.getExampleShortNumber(RegionCode.AD)); assertEquals('1010', shortInfo.getExampleShortNumber(RegionCode.FR)); assertEquals('', shortInfo.getExampleShortNumber(RegionCode.UN001)); assertEquals('', shortInfo.getExampleShortNumber(null));