Browse Source

CPP: Make cpplint happy with stringutils.*

pull/567/head
Philippe Liard 14 years ago
committed by Mihaela Rosca
parent
commit
1b09e6d683
2 changed files with 20 additions and 20 deletions
  1. +14
    -14
      cpp/src/phonenumbers/stringutil.cc
  2. +6
    -6
      cpp/src/phonenumbers/stringutil.h

+ 14
- 14
cpp/src/phonenumbers/stringutil.cc View File

@ -27,7 +27,7 @@ namespace phonenumbers {
using std::equal;
using std::stringstream;
string operator+(const string& s, int n) {
string operator+(const string& s, int n) { // NOLINT(runtime/string)
stringstream stream;
stream << s << n;
@ -171,23 +171,23 @@ int GlobalReplaceSubstring(const string& substring,
// StringHolder class
StringHolder::StringHolder(const string& s) :
string_(&s),
cstring_(NULL),
len_(s.size())
StringHolder::StringHolder(const string& s)
: string_(&s),
cstring_(NULL),
len_(s.size())
{}
StringHolder::StringHolder(const char* s) :
string_(NULL),
cstring_(s),
len_(std::strlen(s))
StringHolder::StringHolder(const char* s)
: string_(NULL),
cstring_(s),
len_(std::strlen(s))
{}
StringHolder::StringHolder(uint64 n) :
converted_string_(SimpleItoa(n)),
string_(&converted_string_),
cstring_(NULL),
len_(converted_string_.length())
StringHolder::StringHolder(uint64 n)
: converted_string_(SimpleItoa(n)),
string_(&converted_string_),
cstring_(NULL),
len_(converted_string_.length())
{}
StringHolder::~StringHolder() {}


+ 6
- 6
cpp/src/phonenumbers/stringutil.h View File

@ -30,7 +30,7 @@ using std::string;
using std::vector;
// Supports string("hello") + 10.
string operator+(const string& s, int n);
string operator+(const string& s, int n); // NOLINT(runtime/string)
// Converts integer to string.
string SimpleItoa(uint64 n);
@ -76,11 +76,11 @@ int GlobalReplaceSubstring(const string& substring, const string& replacement,
// Holds a reference to a std::string or C string. It can also be constructed
// from an integer which is converted to a string.
class StringHolder {
public:
public:
// Don't make the constructors explicit to make the StrCat usage convenient.
StringHolder(const string& s);
StringHolder(const char* s);
StringHolder(uint64 n);
StringHolder(const string& s); // NOLINT(runtime/explicit)
StringHolder(const char* s); // NOLINT(runtime/explicit)
StringHolder(uint64 n); // NOLINT(runtime/explicit)
~StringHolder();
const string* GetString() const {
@ -95,7 +95,7 @@ public:
return len_;
}
private:
private:
const string converted_string_; // Stores the string converted from integer.
const string* const string_;
const char* const cstring_;


Loading…
Cancel
Save