diff --git a/java/libphonenumber/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java b/java/libphonenumber/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java index ddb26f7cb..af1b803ac 100644 --- a/java/libphonenumber/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java +++ b/java/libphonenumber/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java @@ -197,6 +197,7 @@ public class PhoneNumberUtil { diallableCharMap.putAll(asciiDigitMappings); diallableCharMap.put(PLUS_SIGN, PLUS_SIGN); diallableCharMap.put('*', '*'); + diallableCharMap.put('#', '#'); DIALLABLE_CHAR_MAPPINGS = Collections.unmodifiableMap(diallableCharMap); HashMap allPlusNumberGroupings = new HashMap(); diff --git a/java/libphonenumber/test/com/google/i18n/phonenumbers/PhoneNumberUtilTest.java b/java/libphonenumber/test/com/google/i18n/phonenumbers/PhoneNumberUtilTest.java index ce3c28c1a..864f117c2 100644 --- a/java/libphonenumber/test/com/google/i18n/phonenumbers/PhoneNumberUtilTest.java +++ b/java/libphonenumber/test/com/google/i18n/phonenumbers/PhoneNumberUtilTest.java @@ -427,7 +427,7 @@ public class PhoneNumberUtilTest extends TestMetadataTestCase { public void testNormaliseStripNonDiallableCharacters() { String inputNumber = "03*4-56&+a#234"; - String expectedOutput = "03*456+234"; + String expectedOutput = "03*456+#234"; assertEquals("Conversion did not correctly remove non-diallable characters", expectedOutput, PhoneNumberUtil.normalizeDiallableCharsOnly(inputNumber)); diff --git a/java/pending_code_changes.txt b/java/pending_code_changes.txt index c9ffb5d12..57e401849 100644 --- a/java/pending_code_changes.txt +++ b/java/pending_code_changes.txt @@ -3,3 +3,4 @@ Code changes: length or not. This could result in more specific results; whereas before, a number from length 3 to length 6 may have been deemed possible, now we may exclude a number of length 5. + - Add hash (#) as a diallable character. diff --git a/javascript/i18n/phonenumbers/phonenumberutil.js b/javascript/i18n/phonenumbers/phonenumberutil.js index 5ca14d1b4..b42989915 100644 --- a/javascript/i18n/phonenumbers/phonenumberutil.js +++ b/javascript/i18n/phonenumbers/phonenumberutil.js @@ -314,7 +314,8 @@ i18n.phonenumbers.PhoneNumberUtil.DIALLABLE_CHAR_MAPPINGS_ = { '8': '8', '9': '9', '+': i18n.phonenumbers.PhoneNumberUtil.PLUS_SIGN, - '*': '*' + '*': '*', + '#': '#' };