Browse Source

Make JS util test changes to reflect the annotation updates. (#2447)

* Make JS util test changes to reflect the annotation updates (like not null parameters). This is followup to recent cl/300367316.

* Add non-nullable modifier to return type of functions never returning null. More details in cl/300838092

* Removing blank line.
pull/2448/head
penmetsaa 6 years ago
committed by GitHub
parent
commit
2e739a9cb5
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 148 additions and 148 deletions
  1. +1
    -1
      javascript/i18n/phonenumbers/phonenumberutil.js
  2. +146
    -146
      javascript/i18n/phonenumbers/phonenumberutil_test.js
  3. +1
    -1
      javascript/i18n/phonenumbers/shortnumberinfo.js

+ 1
- 1
javascript/i18n/phonenumbers/phonenumberutil.js View File

@ -4334,7 +4334,7 @@ i18n.phonenumbers.PhoneNumberUtil.prototype.buildNationalNumberForParsing_ =
* *
* @param {i18n.phonenumbers.PhoneNumber} numberIn number that we want to copy * @param {i18n.phonenumbers.PhoneNumber} numberIn number that we want to copy
* fields from. * fields from.
* @return {i18n.phonenumbers.PhoneNumber} number with core fields only.
* @return {!i18n.phonenumbers.PhoneNumber} number with core fields only.
* @private * @private
*/ */
i18n.phonenumbers.PhoneNumberUtil.copyCoreFieldsOnly_ = function(numberIn) { i18n.phonenumbers.PhoneNumberUtil.copyCoreFieldsOnly_ = function(numberIn) {


+ 146
- 146
javascript/i18n/phonenumbers/phonenumberutil_test.js
File diff suppressed because it is too large
View File


+ 1
- 1
javascript/i18n/phonenumbers/shortnumberinfo.js View File

@ -385,7 +385,7 @@ i18n.phonenumbers.ShortNumberInfo.prototype.getRegionCodeForShortNumberFromRegio
/** /**
* Convenience method to get a list of what regions the library has metadata for * Convenience method to get a list of what regions the library has metadata for
* @return {Array<string>} the list of region codes
* @return {!Array<string>} the list of region codes
* @package * @package
*/ */
i18n.phonenumbers.ShortNumberInfo.prototype.getSupportedRegions = function() { i18n.phonenumbers.ShortNumberInfo.prototype.getSupportedRegions = function() {


Loading…
Cancel
Save