Browse Source

Merge pull request #731 from dlyongemallo/master

fix NPE in ShortNumberInfo when isPossibleNumber is called on a region with no ShortNumberMetadata
pull/718/merge
Andy Staudacher 11 years ago
parent
commit
36ceea24ac
2 changed files with 6 additions and 0 deletions
  1. +3
    -0
      cpp/src/phonenumbers/shortnumberinfo.cc
  2. +3
    -0
      java/libphonenumber/src/com/google/i18n/phonenumbers/ShortNumberInfo.java

+ 3
- 0
cpp/src/phonenumbers/shortnumberinfo.cc View File

@ -126,6 +126,9 @@ bool ShortNumberInfo::IsPossibleShortNumber(const PhoneNumber& number) const {
for (list<string>::const_iterator it = region_codes.begin();
it != region_codes.end(); ++it) {
const PhoneMetadata* phone_metadata = GetMetadataForRegion(*it);
if (!phone_metadata) {
continue;
}
if (matcher_api_->MatchesPossibleNumber(short_number,
phone_metadata->general_desc())) {
return true;


+ 3
- 0
java/libphonenumber/src/com/google/i18n/phonenumbers/ShortNumberInfo.java View File

@ -156,6 +156,9 @@ public class ShortNumberInfo {
String shortNumber = getNationalSignificantNumber(number);
for (String region : regionCodes) {
PhoneMetadata phoneMetadata = MetadataManager.getShortNumberMetadataForRegion(region);
if (phoneMetadata == null) {
continue;
}
if (matcherApi.matchesPossibleNumber(shortNumber, phoneMetadata.getGeneralDesc())) {
return true;
}


Loading…
Cancel
Save