diff --git a/java/demo/src/com/google/phonenumbers/PhoneNumberParserServlet.java b/java/demo/src/com/google/phonenumbers/PhoneNumberParserServlet.java index 3b389d09e..4ab45ec5d 100644 --- a/java/demo/src/com/google/phonenumbers/PhoneNumberParserServlet.java +++ b/java/demo/src/com/google/phonenumbers/PhoneNumberParserServlet.java @@ -103,7 +103,7 @@ public class PhoneNumberParserServlet extends HttpServlet { StringBuilder output; resp.setContentType("text/html"); resp.setCharacterEncoding(UTF_8.name()); - if (fileContents.length() == 0) { + if (fileContents == null || fileContents.length() == 0) { // Redirect to a URL with the given input encoded in the query parameters. Locale geocodingLocale = new Locale(languageCode, regionCode); resp.sendRedirect(getPermaLinkURL(phoneNumber, defaultCountry, geocodingLocale, @@ -196,7 +196,7 @@ public class PhoneNumberParserServlet extends HttpServlet { absoluteURL ? "http://libphonenumber.appspot.com/phonenumberparser" : "/phonenumberparser"); try { permaLink.append("?number=" + URLEncoder.encode(phoneNumber, UTF_8.name())); - if (!defaultCountry.isEmpty()) { + if (defaultCountry != null && !defaultCountry.isEmpty()) { permaLink.append("&country=" + URLEncoder.encode(defaultCountry, UTF_8.name())); } if (!geocodingLocale.getLanguage().equals(ENGLISH.getLanguage()) || diff --git a/java/release_notes.txt b/java/release_notes.txt index cc426b06a..287f2dab1 100644 --- a/java/release_notes.txt +++ b/java/release_notes.txt @@ -1,3 +1,7 @@ +Pending changes +Code changes: + - Fix two places in demo where NPEs can occur on bad input + Jan 28, 2016: libphonenumber-7.2.4 Metadata changes: - Updated phone metadata for region code(s):