From 7415b62a25651b0ebc57b7c1c9bf777358a28004 Mon Sep 17 00:00:00 2001 From: Keghani Kouzoujian Date: Wed, 14 Jun 2017 18:11:54 +0200 Subject: [PATCH] Add tests for [-1] possible lengths (#1788) --- .../BuildMetadataFromXmlTest.java | 24 ++++++++++++++----- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/tools/java/common/test/com/google/i18n/phonenumbers/BuildMetadataFromXmlTest.java b/tools/java/common/test/com/google/i18n/phonenumbers/BuildMetadataFromXmlTest.java index 750e3d191..3d309c63c 100644 --- a/tools/java/common/test/com/google/i18n/phonenumbers/BuildMetadataFromXmlTest.java +++ b/tools/java/common/test/com/google/i18n/phonenumbers/BuildMetadataFromXmlTest.java @@ -775,14 +775,26 @@ public class BuildMetadataFromXmlTest extends TestCase { + " " + "" + ""); - PhoneNumberDesc.Builder phoneNumberDesc; - phoneNumberDesc = BuildMetadataFromXml.processPhoneNumberDescElement( + PhoneNumberDesc.Builder fixedLine; + PhoneNumberDesc.Builder mobile; + + fixedLine = BuildMetadataFromXml.processPhoneNumberDescElement( generalDesc, territoryElement, "fixedLine"); - assertEquals(2, phoneNumberDesc.getPossibleLengthCount()); - assertEquals(4, phoneNumberDesc.getPossibleLength(0)); - assertEquals(13, phoneNumberDesc.getPossibleLength(1)); - assertEquals(1, phoneNumberDesc.getPossibleLengthLocalOnlyCount()); + mobile = BuildMetadataFromXml.processPhoneNumberDescElement( + generalDesc, territoryElement, "mobile"); + + assertEquals(2, fixedLine.getPossibleLengthCount()); + assertEquals(4, fixedLine.getPossibleLength(0)); + assertEquals(13, fixedLine.getPossibleLength(1)); + assertEquals(1, fixedLine.getPossibleLengthLocalOnlyCount()); + + // We use [-1] to denote that there are no possible lengths; we don't leave it empty, since for + // compression reasons, we use the empty list to mean that the generalDesc possible lengths + // apply. + assertEquals(1, mobile.getPossibleLengthCount()); + assertEquals(-1, mobile.getPossibleLength(0)); + assertEquals(0, mobile.getPossibleLengthLocalOnlyCount()); } public void testSetPossibleLengthsGeneralDesc_BuiltFromChildElements() throws Exception {