From ab5df263eb65e8e59836a1d46abf2b8fc7f9744f Mon Sep 17 00:00:00 2001 From: Keghani Kouzoujian Date: Mon, 13 Mar 2017 14:35:37 +0100 Subject: [PATCH] Update Visual Studio documentation (#1597) --- FAQ.md | 2 ++ cpp/README | 16 ++++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/FAQ.md b/FAQ.md index cb6d2962e..8c83b0d59 100644 --- a/FAQ.md +++ b/FAQ.md @@ -287,6 +287,8 @@ contribute a PR and/or review and test out someone else's PR, please chime in on these links, or email the [discussion group](https://groups.google.com/group/libphonenumber-discuss): +* [#1010](https://github.com/googlei18n/libphonenumber/issues/1010) to require + Visual Studio 2015 update 2 or later on Windows * PR [#1090](https://github.com/googlei18n/libphonenumber/pull/1090) / [#824](https://github.com/googlei18n/libphonenumber/issues/824) to "Replace POSIX directory operations by Boost Filesystem" diff --git a/cpp/README b/cpp/README index 8bbdd8e79..088bd274d 100644 --- a/cpp/README +++ b/cpp/README @@ -263,6 +263,22 @@ Troubleshooting CMake via ccmake Building the library on Windows (Visual Studio) ----------------------------------------------- +We recommend that libphonenumber on Windows be built with Visual Studio 2015 +Update 2 (https://www.visualstudio.com/en-us/news/releasenotes/vs2015-update2-vs) +or later. + +This enables support of plain UTF-8 source files, for which you also need to specify +the /utf-8 option in build files; see "New Options in VS2015 Update 2" at +https://blogs.msdn.microsoft.com/vcblog/2016/02/22/new-options-for-managing-character-sets-in-the-microsoft-cc-compiler/, +or a Chrome patch for an example: +https://codereview.chromium.org/2488853002/diff/80001/build/config/compiler/BUILD.gn + +Without this version and the option, your compilation will have warnings when +setting the codepage for non-Unicode applications on Windows to one of the CJK +code pages, since libphonenumber has UTF-8 strings in source files. While these +are only comments (as opposed to string literals) the warnings can be +suppressed, but we reserve the right to introduce UTF-8 string literals. + The library was tested with Visual Studio 2010. You will need to manually fetch and install the following dependencies: