Browse Source

TOOLS: Update Metadata generation code to output metadata on multiple lines.

pull/567/head
Philip Liard 15 years ago
committed by Mihaela Rosca
parent
commit
abe9065a91
2 changed files with 14 additions and 4 deletions
  1. +13
    -3
      tools/java/cpp-build/src/com/google/i18n/phonenumbers/tools/BuildMetadataCppFromXml.java
  2. +1
    -1
      tools/java/cpp-build/test/com/google/i18n/phonenumbers/tools/BuildMetadataCppFromXmlTest.java

+ 13
- 3
tools/java/cpp-build/src/com/google/i18n/phonenumbers/tools/BuildMetadataCppFromXml.java View File

@ -152,9 +152,9 @@ public class BuildMetadataCppFromXml extends Command {
pw.write(CopyrightNotice.TEXT); pw.write(CopyrightNotice.TEXT);
pw.println(String.format("#include \"%s.h\"", baseFilename)); pw.println(String.format("#include \"%s.h\"", baseFilename));
pw.println(); pw.println();
pw.print(String.format("static const unsigned char %s_data[] = { ", baseFilename));
pw.print(String.format("static const unsigned char %s_data[] = {", baseFilename));
emitStaticArrayCode(pw); emitStaticArrayCode(pw);
pw.println(" };");
pw.println("};");
pw.println(); pw.println();
pw.println(String.format("int %s_size() {", baseFilename)); pw.println(String.format("int %s_size() {", baseFilename));
@ -174,9 +174,19 @@ public class BuildMetadataCppFromXml extends Command {
*/ */
void emitStaticArrayCode(PrintWriter pw) throws IOException { void emitStaticArrayCode(PrintWriter pw) throws IOException {
byte[] buf = binaryStream.toByteArray(); byte[] buf = binaryStream.toByteArray();
pw.print("\n ");
for (int i = 0; i < buf.length; i++) { for (int i = 0; i < buf.length; i++) {
pw.printf("0x%02X, ", buf[i]);
String format = "0x%02X";
if (i == buf.length - 1) {
format += "\n";
} else if ((i + 1) % 13 == 0) { // 13 bytes per line to have lines of 79 characters.
format += ",\n ";
} else {
format += ", ";
}
pw.printf(format, buf[i]);
} }
pw.flush(); pw.flush();
binaryStream.flush(); binaryStream.flush();


+ 1
- 1
tools/java/cpp-build/test/com/google/i18n/phonenumbers/tools/BuildMetadataCppFromXmlTest.java View File

@ -49,7 +49,7 @@ public class BuildMetadataCppFromXmlTest {
buildMetadataCppFromXml.setBinaryStream(stream); buildMetadataCppFromXml.setBinaryStream(stream);
buildMetadataCppFromXml.emitStaticArrayCode(printWriter); buildMetadataCppFromXml.emitStaticArrayCode(printWriter);
assertEquals("0xCA, 0xFE, 0xBA, 0xBE, ", result.toString());
assertEquals("\n 0xCA, 0xFE, 0xBA, 0xBE\n", result.toString());
} catch (IOException e) { } catch (IOException e) {
fail(e.getMessage()); fail(e.getMessage());
} }


Loading…
Cancel
Save