From c47097bc6cfa3f5ef50997c8cd28530cd3ef5955 Mon Sep 17 00:00:00 2001 From: penmetsaa Date: Wed, 5 Sep 2018 10:08:14 +0530 Subject: [PATCH] Cleanup in continuation to support of Russian extension characters (#2250) * Cleanup in continuation to support to russian extension characters * Nit: \xBE (uppercase E) for consistency --- cpp/src/phonenumbers/phonenumberutil.cc | 2 +- .../src/com/google/i18n/phonenumbers/PhoneNumberUtil.java | 2 +- .../com/google/i18n/phonenumbers/PhoneNumberUtilTest.java | 2 +- javascript/i18n/phonenumbers/phonenumberutil.js | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/cpp/src/phonenumbers/phonenumberutil.cc b/cpp/src/phonenumbers/phonenumberutil.cc index 5d33f3d25..de0bdda03 100644 --- a/cpp/src/phonenumbers/phonenumberutil.cc +++ b/cpp/src/phonenumbers/phonenumberutil.cc @@ -227,7 +227,7 @@ string CreateExtnPattern(const string& single_extn_symbols) { "[:\\..]?[  \\t,-]*", capturing_extn_digits, "#?|" */ "[ \xC2\xA0\\t,]*(?:e?xt(?:ensi(?:o\xCC\x81?|\xC3\xB3))?n?|" "(?:\xEF\xBD\x85)?\xEF\xBD\x98\xEF\xBD\x94(?:\xEF\xBD\x8E)?|" - "доб|[", single_extn_symbols, "]|int|" + "\xD0\xB4\xD0\xBE\xD0\xB1|[", single_extn_symbols, "]|int|" "\xEF\xBD\x89\xEF\xBD\x8E\xEF\xBD\x94|anexo)" "[:\\.\xEF\xBC\x8E]?[ \xC2\xA0\\t,-]*", capturing_extn_digits, "#?|[- ]+([", kDigits, "]{1,5})#")); diff --git a/java/libphonenumber/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java b/java/libphonenumber/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java index 03c028d49..0e3daa1c4 100644 --- a/java/libphonenumber/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java +++ b/java/libphonenumber/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java @@ -341,7 +341,7 @@ public class PhoneNumberUtil { // form with the combining acute accent. return (RFC3966_EXTN_PREFIX + CAPTURING_EXTN_DIGITS + "|" + "[ \u00A0\\t,]*" + "(?:e?xt(?:ensi(?:o\u0301?|\u00F3))?n?|\uFF45?\uFF58\uFF54\uFF4E?|" - + "доб|" + "[" + singleExtnSymbols + "]|int|anexo|\uFF49\uFF4E\uFF54)" + + "\u0434\u043E\u0431|" + "[" + singleExtnSymbols + "]|int|anexo|\uFF49\uFF4E\uFF54)" + "[:\\.\uFF0E]?[ \u00A0\\t,-]*" + CAPTURING_EXTN_DIGITS + "#?|" + "[- ]+(" + DIGITS + "{1,5})#"); } diff --git a/java/libphonenumber/test/com/google/i18n/phonenumbers/PhoneNumberUtilTest.java b/java/libphonenumber/test/com/google/i18n/phonenumbers/PhoneNumberUtilTest.java index 36ea9f094..299c01dac 100644 --- a/java/libphonenumber/test/com/google/i18n/phonenumbers/PhoneNumberUtilTest.java +++ b/java/libphonenumber/test/com/google/i18n/phonenumbers/PhoneNumberUtilTest.java @@ -2662,7 +2662,7 @@ public class PhoneNumberUtilTest extends TestMetadataTestCase { phoneUtil.parse("8 (423) 202-25-11\u0434\u043E\u0431100", RegionCode.RU)); // In upper case assertEquals(ruWithExtension, - phoneUtil.parse("8 (423) 202-25-11, \u0414\u041E\u0431. 100", RegionCode.RU)); + phoneUtil.parse("8 (423) 202-25-11, \u0414\u041E\u0411. 100", RegionCode.RU)); // Test that if a number has two extensions specified, we ignore the second. PhoneNumber usWithTwoExtensionsNumber = new PhoneNumber(); diff --git a/javascript/i18n/phonenumbers/phonenumberutil.js b/javascript/i18n/phonenumbers/phonenumberutil.js index 8f1ed1b90..e72a460ec 100644 --- a/javascript/i18n/phonenumbers/phonenumberutil.js +++ b/javascript/i18n/phonenumbers/phonenumberutil.js @@ -778,11 +778,11 @@ i18n.phonenumbers.PhoneNumberUtil.CAPTURING_EXTN_DIGITS_ = i18n.phonenumbers.PhoneNumberUtil.EXTN_PATTERNS_FOR_PARSING_ = i18n.phonenumbers.PhoneNumberUtil.RFC3966_EXTN_PREFIX_ + i18n.phonenumbers.PhoneNumberUtil.CAPTURING_EXTN_DIGITS_ + '|' + - '[ \xA0\\t,]*' + + '[ \u00A0\\t,]*' + '(?:e?xt(?:ensi(?:o\u0301?|\u00F3))?n?|\uFF45?\uFF58\uFF54\uFF4E?|' + - '\u0434\u043E\u0431|\u0414\u041E\u0411|' + + '\u0434\u043E\u0431|' + '[;,x\uFF58#\uFF03~\uFF5E]|int|anexo|\uFF49\uFF4E\uFF54)' + - '[:\\.\uFF0E]?[ \xA0\\t,-]*' + + '[:\\.\uFF0E]?[ \u00A0\\t,-]*' + i18n.phonenumbers.PhoneNumberUtil.CAPTURING_EXTN_DIGITS_ + '#?|' + '[- ]+([' + i18n.phonenumbers.PhoneNumberUtil.VALID_DIGITS_ + ']{1,5})#';