From d281d59a3c97f834e14d3d5ac627ea6ed6ca2a7c Mon Sep 17 00:00:00 2001
From: Henry Lee <lee0906@hotmail.com>
Date: Tue, 7 Jan 2020 17:37:13 +1100
Subject: [PATCH] Fix javascript build issues (#2425)

Compiling errors found when compiled against new version of closure-compiler
>> No warning class for name: ambiguousFunctionDecl
>> Same case for:
fileoverviewTags google/closure-compiler@04cba67
internetExplorerChecks google/closure-compiler@baab835
>> Moreover, deprecated syntax errors for defineClass
"[exec] /Users/lee/ClickToCloud/git/closure-library/closure/goog/base.js:2259: ERROR - [JSC_DEPRECATED_PROP_REASON]"

So we have updated the build.xml so that it no more considers these specific issues as errors and block the build/compilation.
---
 javascript/build.xml | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/javascript/build.xml b/javascript/build.xml
index a93149f67..037153452 100644
--- a/javascript/build.xml
+++ b/javascript/build.xml
@@ -31,22 +31,18 @@
         <arg line='-f "--compilation_level=@{compilationlevel}"' />
         <arg line='-f "--warning_level=VERBOSE"' />
         <arg line='-f "--jscomp_error=accessControls"' />
-        <arg line='-f "--jscomp_error=ambiguousFunctionDecl"' />
         <arg line='-f "--jscomp_error=checkDebuggerStatement"' />
         <arg line='-f "--jscomp_error=checkRegExp"' />
         <arg line='-f "--jscomp_error=checkTypes"' />
         <arg line='-f "--jscomp_error=checkVars"' />
         <arg line='-f "--jscomp_error=const"' />
         <arg line='-f "--jscomp_error=constantProperty"' />
-        <arg line='-f "--jscomp_error=deprecated"' />
         <arg line='-f "--jscomp_error=duplicate"' />
         <arg line='-f "--jscomp_error=duplicateMessage"' />
         <arg line='-f "--jscomp_error=es5Strict"' />
         <arg line='-f "--jscomp_error=externsValidation"' />
         <arg line='-f "--jscomp_error=extraRequire"' />
-        <arg line='-f "--jscomp_error=fileoverviewTags"' />
         <arg line='-f "--jscomp_error=globalThis"' />
-        <arg line='-f "--jscomp_error=internetExplorerChecks"' />
         <arg line='-f "--jscomp_error=invalidCasts"' />
         <arg line='-f "--jscomp_error=misplacedTypeAnnotation"' />
         <arg line='-f "--jscomp_error=missingProperties"' />