From 261841eb748f316eee871167f1eceb6a74eaa5ab Mon Sep 17 00:00:00 2001 From: Keghani Kouzoujian Date: Fri, 1 Apr 2016 10:50:37 +0200 Subject: [PATCH 1/2] Update outdated comments about the national significant number in the PhoneNumber proto class documentation. --- resources/phonenumber.proto | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/resources/phonenumber.proto b/resources/phonenumber.proto index 10683430b..1914c00c1 100644 --- a/resources/phonenumber.proto +++ b/resources/phonenumber.proto @@ -26,16 +26,17 @@ package i18n.phonenumbers; message PhoneNumber { // The country calling code for this number, as defined by the International Telecommunication Union -// (ITU). Fox example, this would be 1 for NANPA countries, and 33 for France. +// (ITU). For example, this would be 1 for NANPA countries, and 33 for France. required int32 country_code = 1; // National (significant) Number is defined in International Telecommunication Union (ITU) // Recommendation E.164. It is a language/country-neutral representation of a phone number at a -// country level. For countries which have the concept of Area Code, the National (significant) -// Number contains the area code. It contains a maximum number of digits which equal to 15 - n, -// where n is the number of digits of the country code. Take note that National (significant) Number -// does not contain National(trunk) prefix. Obviously, as a uint64, it will never contain any -// formatting (hypens, spaces, parentheses), nor any alphanumeric spellings. +// country level. For countries which have the concept of an "area code" or "national destination +// code", this is included in the National (significant) Number. Although the ITU says the maximum +// length should be 15, we have found longer numbers in some countries e.g. Germany. +// Note that the National (significant) Number does not contain the National(trunk) prefix. +// Obviously, as a uint64, it will never contain any formatting (hypens, spaces, parentheses), nor +// any alphanumeric spellings. required uint64 national_number = 2; // Extension is not standardized in ITU recommendations, except for being defined as a series of From 7e1748645552da39c4e1ba731e47969d97bdb539 Mon Sep 17 00:00:00 2001 From: Keghani Kouzoujian Date: Tue, 5 Apr 2016 11:33:23 +0200 Subject: [PATCH 2/2] Fix typo (hypen -> hyphen) --- resources/phonenumber.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/phonenumber.proto b/resources/phonenumber.proto index 1914c00c1..12c906203 100644 --- a/resources/phonenumber.proto +++ b/resources/phonenumber.proto @@ -35,7 +35,7 @@ message PhoneNumber { // code", this is included in the National (significant) Number. Although the ITU says the maximum // length should be 15, we have found longer numbers in some countries e.g. Germany. // Note that the National (significant) Number does not contain the National(trunk) prefix. -// Obviously, as a uint64, it will never contain any formatting (hypens, spaces, parentheses), nor +// Obviously, as a uint64, it will never contain any formatting (hyphens, spaces, parentheses), nor // any alphanumeric spellings. required uint64 national_number = 2;