Browse Source

Use setJavadoc instead of accumulating.

pull/3623/head
silviobraendle 1 year ago
committed by Silvio Brändle
parent
commit
dc02a7961d
1 changed files with 2 additions and 9 deletions
  1. +2
    -9
      tools/java/java-build/src/com/google/i18n/phonenumbers/BuildMetadataProtoFromXml.java

+ 2
- 9
tools/java/java-build/src/com/google/i18n/phonenumbers/BuildMetadataProtoFromXml.java View File

@ -378,7 +378,7 @@ public class BuildMetadataProtoFromXml extends Command {
.setModifiers("final")
.setCopyright(Integer.parseInt(copyright));
writer.addToJavadoc(REGION_CODE_CONSTS_JAVADOC);
writer.setJavadoc(REGION_CODE_CONSTS_JAVADOC);
for (String regionCode : regionCodeList) {
String variableName = regionCode.toUpperCase();
@ -423,13 +423,7 @@ public class BuildMetadataProtoFromXml extends Command {
return this;
}
abstract Builder setJavadoc(String javadoc);
private final StringBuilder javadocBuilder = new StringBuilder();
final Builder addToJavadoc(String text) {
javadocBuilder.append(text);
return this;
}
abstract Builder setJavadoc(String javadoc);
abstract Builder setName(String name);
abstract Builder setModifiers(String modifiers);
@ -448,7 +442,6 @@ public class BuildMetadataProtoFromXml extends Command {
abstract ClassWriter autoBuild();
final ClassWriter build() {
setJavadoc(javadocBuilder.toString());
setBody(bodyBuilder.toString());
return autoBuild();
}


Loading…
Cancel
Save