Browse Source

Updating docs for getNumberType (#1863)

pull/1865/merge
lararennie 9 years ago
committed by Keghani Kouzoujian
parent
commit
e24208e0c6
4 changed files with 8 additions and 6 deletions
  1. +1
    -1
      cpp/src/phonenumbers/phonenumberutil.h
  2. +2
    -2
      java/libphonenumber/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java
  3. +3
    -2
      javascript/i18n/phonenumbers/phonenumberutil.js
  4. +2
    -1
      pending_code_changes.txt

+ 1
- 1
cpp/src/phonenumbers/phonenumberutil.h View File

@ -422,7 +422,7 @@ class PhoneNumberUtil : public Singleton<PhoneNumberUtil> {
// be successfully extracted. // be successfully extracted.
bool TruncateTooLongNumber(PhoneNumber* number) const; bool TruncateTooLongNumber(PhoneNumber* number) const;
// Gets the type of a phone number.
// Gets the type of a valid phone number, or UNKNOWN if it is invalid.
PhoneNumberType GetNumberType(const PhoneNumber& number) const; PhoneNumberType GetNumberType(const PhoneNumber& number) const;
// Tests whether a phone number matches a valid pattern. Note this doesn't // Tests whether a phone number matches a valid pattern. Note this doesn't


+ 2
- 2
java/libphonenumber/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java View File

@ -2138,10 +2138,10 @@ public class PhoneNumberUtil {
} }
/** /**
* Gets the type of a phone number.
* Gets the type of a valid phone number.
* *
* @param number the phone number that we want to know the type * @param number the phone number that we want to know the type
* @return the type of the phone number
* @return the type of the phone number, or UNKNOWN if it is invalid
*/ */
public PhoneNumberType getNumberType(PhoneNumber number) { public PhoneNumberType getNumberType(PhoneNumber number) {
String regionCode = getRegionCodeForNumber(number); String regionCode = getRegionCodeForNumber(number);


+ 3
- 2
javascript/i18n/phonenumbers/phonenumberutil.js View File

@ -2807,11 +2807,12 @@ i18n.phonenumbers.PhoneNumberUtil.getNumberDescByType_ =
/** /**
* Gets the type of a phone number.
* Gets the type of a valid phone number.
* *
* @param {i18n.phonenumbers.PhoneNumber} number the phone number that we want * @param {i18n.phonenumbers.PhoneNumber} number the phone number that we want
* to know the type. * to know the type.
* @return {i18n.phonenumbers.PhoneNumberType} the type of the phone number.
* @return {i18n.phonenumbers.PhoneNumberType} the type of the phone number, or
* UNKNOWN if it is invalid.
*/ */
i18n.phonenumbers.PhoneNumberUtil.prototype.getNumberType = i18n.phonenumbers.PhoneNumberUtil.prototype.getNumberType =
function(number) { function(number) {


+ 2
- 1
pending_code_changes.txt View File

@ -1 +1,2 @@
Code changes:
- Documentation fix for getNumberType

Loading…
Cancel
Save