Browse Source

DATA: Change "PhoneNumberMetaData" to "PhoneNumberMetadata" throughout for consistency

pull/567/head
David Yonge-Mallo 13 years ago
committed by Mihaela Rosca
parent
commit
f5a3fd9072
14 changed files with 29 additions and 18 deletions
  1. +3
    -3
      cpp/CMakeLists.txt
  2. +7
    -0
      debian/changelog
  3. +5
    -5
      java/build.xml
  4. +1
    -1
      java/libphonenumber/src/com/google/i18n/phonenumbers/MetadataManager.java
  5. +4
    -0
      java/release_notes.txt
  6. +1
    -1
      javascript/README
  7. +1
    -1
      javascript/i18n/phonenumbers/metadata.js
  8. +1
    -1
      javascript/i18n/phonenumbers/metadatafortesting.js
  9. +1
    -1
      javascript/i18n/phonenumbers/metadatalite.js
  10. +2
    -2
      resources/PhoneNumberAlternateFormats.xml
  11. +0
    -0
      resources/PhoneNumberMetadata.xml
  12. +1
    -1
      resources/PhoneNumberMetadataForTesting.xml
  13. +1
    -1
      resources/phonemetadata.proto
  14. +1
    -1
      tools/java/java-build/src/com/google/i18n/phonenumbers/BuildMetadataProtoFromXml.java

+ 3
- 3
cpp/CMakeLists.txt View File

@ -277,7 +277,7 @@ if (${USE_LITE_METADATA} STREQUAL "ON")
set (METADATA_TARGET "generate-lite-metadata")
add_metadata_gen_target (
${METADATA_TARGET}
"${RESOURCES_DIR}/PhoneNumberMetaData.xml"
"${RESOURCES_DIR}/PhoneNumberMetadata.xml"
"lite_metadata"
"metadata"
)
@ -287,7 +287,7 @@ else ()
set (METADATA_TARGET "generate-metadata")
add_metadata_gen_target (
${METADATA_TARGET}
"${RESOURCES_DIR}/PhoneNumberMetaData.xml"
"${RESOURCES_DIR}/PhoneNumberMetadata.xml"
"metadata"
"metadata"
)
@ -298,7 +298,7 @@ endif ()
set (TEST_METADATA_TARGET "generate-test-metadata")
add_metadata_gen_target (
${TEST_METADATA_TARGET}
"${RESOURCES_DIR}/PhoneNumberMetaDataForTesting.xml"
"${RESOURCES_DIR}/PhoneNumberMetadataForTesting.xml"
"test_metadata"
"metadata"
)


+ 7
- 0
debian/changelog View File

@ -1,3 +1,10 @@
libphonenumber (5.6.1) precise; urgency=low
* Code changes:
- Rename all instances of PhoneNumberMetadata to PhoneNumberMetadata for consistency.
-- David Yonge-Mallo <davinci@google.com> Fri, Jul 12 2013 10:26:53 +0200
libphonenumber (5.6) precise; urgency=low
* Code changes:


+ 5
- 5
java/build.xml View File

@ -32,7 +32,7 @@
<arg value="-jar" />
<arg value="${build.tools.jar}"/>
<arg value="BuildMetadataProtoFromXml"/>
<arg value="--input-file=${resources.dir}/PhoneNumberMetaData.xml"/>
<arg value="--input-file=${resources.dir}/PhoneNumberMetadata.xml"/>
<arg value="--output-dir=${libphonenumber.src.dir}/com/google/i18n/phonenumbers"/>
<arg value="--data-prefix=data/PhoneNumberMetadataProto"/>
<arg value="--mapping-class=CountryCodeToRegionCodeMap"/>
@ -46,7 +46,7 @@
<arg value="-jar" />
<arg value="${build.tools.jar}"/>
<arg value="BuildMetadataProtoFromXml"/>
<arg value="--input-file=${resources.dir}/PhoneNumberMetaDataForTesting.xml"/>
<arg value="--input-file=${resources.dir}/PhoneNumberMetadataForTesting.xml"/>
<arg value="--output-dir=${libphonenumber.test.dir}/com/google/i18n/phonenumbers"/>
<arg value="--data-prefix=data/PhoneNumberMetadataProtoForTesting"/>
<arg value="--mapping-class=CountryCodeToRegionCodeMapForTesting"/>
@ -94,14 +94,14 @@
<arg value="-jar" />
<arg value="${build.tools.jar}"/>
<arg value="BuildMetadataJsonFromXml"/>
<arg value="${resources.dir}/PhoneNumberMetaData.xml"/>
<arg value="${resources.dir}/PhoneNumberMetadata.xml"/>
<arg value="${javascript.dir}/i18n/phonenumbers/metadata.js"/>
</exec>
<exec executable="java">
<arg value="-jar" />
<arg value="${build.tools.jar}"/>
<arg value="BuildMetadataJsonFromXml"/>
<arg value="${resources.dir}/PhoneNumberMetaData.xml"/>
<arg value="${resources.dir}/PhoneNumberMetadata.xml"/>
<arg value="${javascript.dir}/i18n/phonenumbers/metadatalite.js"/>
<arg value="true"/> <!-- Lite metadata. -->
</exec>
@ -109,7 +109,7 @@
<arg value="-jar" />
<arg value="${build.tools.jar}"/>
<arg value="BuildMetadataJsonFromXml"/>
<arg value="${resources.dir}/PhoneNumberMetaDataForTesting.xml"/>
<arg value="${resources.dir}/PhoneNumberMetadataForTesting.xml"/>
<arg value="${javascript.dir}/i18n/phonenumbers/metadatafortesting.js"/>
</exec>
</target>


+ 1
- 1
java/libphonenumber/src/com/google/i18n/phonenumbers/MetadataManager.java View File

@ -33,7 +33,7 @@ import java.util.logging.Logger;
/**
* Class encapsulating loading of PhoneNumber Metadata information. Currently this is used only for
* additional data files such as PhoneNumberAlternateFormats, but in the future it is envisaged it
* would handle the main metadata file (PhoneNumberMetaData.xml) as well.
* would handle the main metadata file (PhoneNumberMetadata.xml) as well.
*
* @author Lara Rennie
*/


+ 4
- 0
java/release_notes.txt View File

@ -1,3 +1,7 @@
Jul 12, 2013: libphonenumber-5.6.1
* Code changes:
- Rename all instances of PhoneNumberMetadata to PhoneNumberMetadata for consistency.
Jun 05, 2013: libphonenumber-5.6
* Code changes:
- Fix for as-you-type-formatting bug affecting countries with no national prefix


+ 1
- 1
javascript/README View File

@ -68,7 +68,7 @@ project:
mvn -f tools/java/java-build/pom.xml package
2. If the phone number metadata in the XML format has changed
(resources/PhoneNumberMetaData.xml)
(resources/PhoneNumberMetadata.xml)
run the following commands to regenerate metadata.js and
metadatafortesting.js:


+ 1
- 1
javascript/i18n/phonenumbers/metadata.js View File

@ -17,7 +17,7 @@
/**
* @fileoverview Generated metadata for file
* ../resources/PhoneNumberMetaData.xml
* ../resources/PhoneNumberMetadata.xml
* @author Nikolaos Trogkanis
*/


+ 1
- 1
javascript/i18n/phonenumbers/metadatafortesting.js View File

@ -17,7 +17,7 @@
/**
* @fileoverview Generated metadata for file
* ../resources/PhoneNumberMetaDataForTesting.xml
* ../resources/PhoneNumberMetadataForTesting.xml
* @author Nikolaos Trogkanis
*/


+ 1
- 1
javascript/i18n/phonenumbers/metadatalite.js View File

@ -17,7 +17,7 @@
/**
* @fileoverview Generated metadata for file
* ../resources/PhoneNumberMetaData.xml
* ../resources/PhoneNumberMetadata.xml
* @author Nikolaos Trogkanis
*/


+ 2
- 2
resources/PhoneNumberAlternateFormats.xml View File

@ -18,7 +18,7 @@
Additional Phone Number Formatting information, containing alternative
formats that are commonly used when writing phone numbers in certain
countries. Note that this is in addition to the formatting information
provided by the main PhoneNumberMetaData.xml file - formatting patterns
provided by the main PhoneNumberMetadata.xml file - formatting patterns
should not be duplicated.
Note also that only the most specific leading-digits pattern is present for
@ -27,7 +27,7 @@
on alternate formatting patterns.
For regions that share a country calling code, only the region with
mainCountryForCode set to true in PhoneNumberMetaData.xml should be present
mainCountryForCode set to true in PhoneNumberMetadata.xml should be present
here.
Note: Territories are in alphabetical order by their IDs, which are based on ISO 3166-1


resources/PhoneNumberMetaData.xml → resources/PhoneNumberMetadata.xml View File


resources/PhoneNumberMetaDataForTesting.xml → resources/PhoneNumberMetadataForTesting.xml View File


+ 1
- 1
resources/phonemetadata.proto View File

@ -16,7 +16,7 @@
// Definition of protocol buffer for holding metadata for international
// telephone numbers. The fields here correspond exactly to those in
// resources/PhoneNumberMetaData.xml.
// resources/PhoneNumberMetadata.xml.
// @author Shaopeng Jia
syntax = "proto2";


+ 1
- 1
tools/java/java-build/src/com/google/i18n/phonenumbers/BuildMetadataProtoFromXml.java View File

@ -71,7 +71,7 @@ public class BuildMetadataProtoFromXml extends Command {
"\n" +
"Example command line invocation:\n" +
CLASS_NAME + " \\\n" +
" --" + INPUT_FILE + "=resources/PhoneNumberMetaData.xml \\\n" +
" --" + INPUT_FILE + "=resources/PhoneNumberMetadata.xml \\\n" +
" --" + OUTPUT_DIR + "=java/libphonenumber/src/com/google/i18n/phonenumbers \\\n" +
" --" + DATA_PREFIX + "=data/PhoneNumberMetadataProto \\\n" +
" --" + MAPPING_CLASS + "=CountryCodeToRegionCodeMap \\\n" +


Loading…
Cancel
Save