* ShortNumberInfo metadata tooling - add missing fields to generated JSON.
Adjust javascript metadata generation tooling to include PhoneMetadata proto fields 29,30,31, and 33 that were previously excluded which are now needed for ShortNumberInfo.
* Add shortnumberinfo metadata to build metadata golden tests.
* Remove inaccurate comments in build tooling
* Add namespace to BuildMetadataJsonFromXml to support tool reuse
* Use updated build tooling to generate short number metadata file
* update phonemetadata.pb.js to match the current proto definition
* remove field 7 from phonemetadata.pb.js
* Update build tool to correctly namespacee the generated metadata files
* Stop field 32 from being populated as it is not used in the APIs
* remove metadata accessors for field 32.
* Add tests for connectsToEmergenyNumber and isEmergencyNumber.
Updated linter to include shortnumberinfo related files, and fixed some
lint issues existing with PhoneNumberUtil files.
* ShortNumberInfo functionality and tests ported. Unformatted and missing jsdoc
* Added comments, and fixed as many lint issues as possible.
* lint and comment review comments from andyst addressed.
* Add a golden metadata build test for short number metadata.
* Revert changes to the original phone metadata golden tests.
* Fix a lot of linting and jsdoc typing errors caught by the compiler.
* Add ShortNumberInfo to the javascript demo pages.
* Add ShortNumberIInfo porting to pending_code_changes.
* Add constants to golden tests.
* Update the build tooling
* uUdate pending changes to differentiate build and code changes
* Update build file, fix small test closure compilation issues
* Regenerate short number metadata to account for metadata updates between original generation and now.
* Move requires to alphabetical order
This hasn't been used for a long time.
Deleted all methods that refer to this, and removed the field from the test XML file (somehow this was missed) as well.
Regenerated jars - because we no longer write a boolean to indicate whether we have the possible number pattern or not all the java metadata files needed regenerating too.
Deleted some data from the js phone metadata implementation that isn't used by js as well (national number matcher pattern)
This enum won't be noticed by most users, because the country_code_source field of the phone number is only populated with ParseAndKeepRawInput, and in this case, this enum won't be used.
However, it provides a better result for users who incorrectly call parse() and then getCountryCodeSource() and expect to get a sensible answer; now they will get UNSPECIFIED instead of FROM_NUMBER_WITH_PLUS_SIGN which was the default before. In JS this method returns null, but getCountryCodeSourceOrDefault() will now return UNSPECIFIED instead.
The numeric values of the existing enums have not changed (relevant for JS and C++) and in Java the new enum was added to the end so that any stored serialized phone numbers should be able to be restored as they were before.
Suggested in issue #1218
* It was confusing and unnecessary. Not every country that has short numbers beginning with a 0 had it, and it is not the only digit that could overlap with a national prefix and hence be interpreted incorrectly.
Andy Staudacher
penmetsaa
James Wright
SumathiSundara
kkeshava
lararennie
Keghani Kouzoujian