Note that the metadata files were not uploaded to appspot because they were too
large. Here is the list of the files affected by this change (generated by
Git):
cpp/src/phonenumbers/lite_metadata.cc
cpp/src/phonenumbers/logger.h
cpp/src/phonenumbers/metadata.cc
cpp/src/phonenumbers/phonenumbermatcher.cc
cpp/src/phonenumbers/phonenumberutil.cc
cpp/src/phonenumbers/phonenumberutil.h
cpp/src/phonenumbers/region_code.h
cpp/src/phonenumbers/stringutil.cc
cpp/src/phonenumbers/stringutil.h
cpp/test/phonenumbers/asyoutypeformatter_test.cc
cpp/test/phonenumbers/phonenumbermatcher_test.cc
cpp/test/phonenumbers/phonenumberutil_test.cc
cpp/test/phonenumbers/stringutil_test.cc
This CL also fixes the issue reported by Aaron about the logger being invoked
before it is initialized.
Review URL: https://codereview.appspot.com/5786065
This file was not up-to-date which made some unit tests fail in Chrome.
Note that the file is not displayed on rietveld since it is too large.
Review URL: https://codereview.appspot.com/5636052
That lets the demo be part of the libphonenumber Maven project thus adds the following benefits:
- Automatically update the version of the demo and the libphonenumber artifact the demo depends on when performing a release.
- Let Maven handle the deployment of the demo to AppEngine without any need to install the AppEngine SDK.
- No need to push the dependency JARs (servlet, apache common fileupload/io) even if they are still here to let you use Ant if you prefer.
Note that this CL depends on CL 5395054.
Review URL: http://codereview.appspot.com/5405041
This CL (depending on CL 5376090) adds the Maven support for the offline phone number geocoder.
All the geocoding-related code/data is moved to the new directory java/geocoder.
Additionally a pom.xml file is added to java/ and java/geocoder/.
The pom.xml file located in java/ is the parent pom file which contains the configuration (SCM, developers, encoding...) that applies to both the libphonenumber and geocoder modules.
The libphonenumber and geocoder Maven modules inherit from this parent pom file therefore they don't need to duplicate this configuration.
I also moved build.xml and release_notes.txt back to java/.
BUG=57
Review URL: http://codereview.appspot.com/5395054
PhoneNumberUtil.resetInstance() should always be used instead. This omission should not be hidden by unit tests that fork.
That also makes the external version consistent with the internal one in which unit tests don't seem to be executed by default in isolated processes.
Review URL: http://codereview.appspot.com/5341042