This is similar to the fix of #822.
Also update README to cover Mac installation.
This rolls back the cmake minimum version bump in #975 since it was
backwards-incompatible, and the following #984. Not expected to cause
any new user-facing regressions, but expected to solve any that were
introduced with #975.
* New useful getExampleNumber methods (for testing) - one for invalid
numbers and one for getting a number of a particular type without
specifying a country.
alternate formats to be included to be found. This means that if the
user doesn't have this option set to true, the tests won't be run (they
would otherwise fail).
This is necessary to guarantee that parallel builds will succeed, all
top-level targets that include geocoding_data.cc in their builds need
explicitly listed dependencies on generate_geocoding_data to ensure that
generation of the file has finished before it is being used.
The preprocessor expression defined(COMPILER_GCC) is used in code copied
from the Chromium project, but COMPILER_GCC is not defined by GCC itself,
but by the following expression in Chromium's build_config.h:
#if defined(__GNUC__)
#define COMPILER_GCC 1
#elif // ...
It must therefore be changed when copying the code out of the Chromium
code base.
This reverts commit df876cedb5.
This commit broke internal builds with the error message:
----
CMake Error at CMakeLists.txt:422 (target_link_libraries):
Cannot specify link libraries for target "phonenumber" which is not built
by this project.
----
Includes corresponding changes for C++ and JavaScript as well to keep the implementations in sync. (C++ and JS didn't exhibit buggy behavior because the corresponding substring methods don't throw errors for invalid start positions.)
Bugfix for https://github.com/googlei18n/libphonenumber/issues/592