RuhNetConsulting/libphonenumber - libphonenumber - RuhNet Code Vault

Author	SHA1	Message	Date
penmetsaa	5719f3a724	More usage of abseil packages. Especially for string util usages. (#2734 ) - Faced link errors stemmed from mismatch of api definitions of absl::node_hash_set. So explicitly mentioned this lib as dependency during linking. This is common case/solution for absl hash set lib's link errors as per community. - Decided to continued to have wrapper (stringutil), so that in future it's easy if we decided to change implementation; client code is safe. Changed most of the implementations & data structures in stringutil, to use abseil stuffs more. - Though absl::string_view is suitable for most cases where we want immutable/read-only string structures, limiting to stringutil apis, not changing public API signatures (even though no compliance issue); reason: reduce dependency on abseil libs. - Abseil specific changes done: - std::set => absl::node_hash_set - std::map => absl::node_hash_map - Using absl alternatives for “SplitStringUsing” API and “StringHolder” class impl. - Replaced manual impl of prefix and suffix checks with absl::StartsWith() and absl::EndsWith. - Similarly used absl::StrReplaceAll, absl::StrCat, absl::StrAppend where possible; and for type conversion apis. - Note: Tried applying parameter packs to replace manually written duplicate ```StrCat``` apis (for accommodating more number of parameters of same type), but it did not go well when different type arguments passed. Eg char, int types to be converted to StringHolder; faced constructor implicit conversion issues.	4 years ago
penmetsaa	874af79377	Some performance improvements to CPP lib based on absl packages (#2703 ) @API updates: - Migrating from associative containers to more performant types. Eg: map to absl::btree_map. - Synchronise the write access to map "AreaCodeMaps" using absl::Mutex locking api. - Use more of absl:strings packages like absl::StrReplaceAll @Build updates: - To build (CMake) against absl packages, the minimum version of compiler is CPP11+, whereas earlier we are not mandating this. - We are upgrading CMAKE version also to automate building the external absl packages. The change is announced. Please report issues in case of any breakages. https://issuetracker.google.com/issues?q=componentid:192347%20555	4 years ago
Fredrik Roubert	2e074af243	CPP: Update CMake rules for Google Test to not require a pre-compiled static library but be able to build the library from source as current practice is. Review URL: https://codereview.appspot.com/6602047	13 years ago
Fredrik Roubert	60db87a603	CPP: Link generate_geocoding_data_test with pthread.	13 years ago
Philippe Liard	ac08bfe262	CPP: Add geocoding data generator.	14 years ago