libphonenumber

1682 Commits

63 Branches

439 MiB

Tree: 74ec582721

Commit Graph

Author	SHA1	Message	Date
penmetsaa	8872bb1d8b	Fixing brittle unit test of checking example short number. (#2284 ) * Fixing brittle unit test of checking example short number * Making same changes in CPP and Java	7 years ago
penmetsaa	b7c385cb33	Update ShortNumberInfo test regarding example number change. (#2268 ) * Update ShortNumberInfo test regarding example number change for region AM. Unlike PhoneNumberUtilTest, ShortNumberInfoTest uses real metadata for unit testing. * Changing the region as Travis tests do not pass with old short metadata of AM * Making same changes in CPP and JS	7 years ago
James Wright	41a070a207	Add Short Number capabilities to libphonenumber-javascript. (#2122 ) * ShortNumberInfo metadata tooling - add missing fields to generated JSON. Adjust javascript metadata generation tooling to include PhoneMetadata proto fields 29,30,31, and 33 that were previously excluded which are now needed for ShortNumberInfo. * Add shortnumberinfo metadata to build metadata golden tests. * Remove inaccurate comments in build tooling * Add namespace to BuildMetadataJsonFromXml to support tool reuse * Use updated build tooling to generate short number metadata file * update phonemetadata.pb.js to match the current proto definition * remove field 7 from phonemetadata.pb.js * Update build tool to correctly namespacee the generated metadata files * Stop field 32 from being populated as it is not used in the APIs * remove metadata accessors for field 32. * Add tests for connectsToEmergenyNumber and isEmergencyNumber. Updated linter to include shortnumberinfo related files, and fixed some lint issues existing with PhoneNumberUtil files. * ShortNumberInfo functionality and tests ported. Unformatted and missing jsdoc * Added comments, and fixed as many lint issues as possible. * lint and comment review comments from andyst addressed. * Add a golden metadata build test for short number metadata. * Revert changes to the original phone metadata golden tests. * Fix a lot of linting and jsdoc typing errors caught by the compiler. * Add ShortNumberInfo to the javascript demo pages. * Add ShortNumberIInfo porting to pending_code_changes. * Add constants to golden tests. * Update the build tooling * uUdate pending changes to differentiate build and code changes * Update build file, fix small test closure compilation issues * Regenerate short number metadata to account for metadata updates between original generation and now. * Move requires to alphabetical order	8 years ago

Author

SHA1

Message

Date

penmetsaa

8872bb1d8b

Fixing brittle unit test of checking example short number. (#2284 )

* Fixing brittle unit test of checking example short number

* Making same changes in CPP and Java

7 years ago

penmetsaa

b7c385cb33

Update ShortNumberInfo test regarding example number change. (#2268 )

* Update ShortNumberInfo test regarding example number change for region AM. Unlike PhoneNumberUtilTest, ShortNumberInfoTest uses real metadata for unit testing.

* Changing the region as Travis tests do not pass with old short metadata of AM

* Making same changes in CPP and JS

7 years ago

James Wright

41a070a207

Add Short Number capabilities to libphonenumber-javascript. (#2122 )

* ShortNumberInfo metadata tooling - add missing fields to generated JSON.

Adjust javascript metadata generation tooling to include PhoneMetadata proto fields 29,30,31, and 33 that were previously excluded which are now needed for ShortNumberInfo.

* Add shortnumberinfo metadata to build metadata golden tests.

* Remove inaccurate comments in build tooling

* Add namespace to BuildMetadataJsonFromXml to support tool reuse

* Use updated build tooling to generate short number metadata file

* update phonemetadata.pb.js to match the current proto definition

* remove field 7 from phonemetadata.pb.js

* Update build tool to correctly namespacee the generated metadata files

* Stop field 32 from being populated as it is not used in the APIs

* remove metadata accessors for field 32.

* Add tests for connectsToEmergenyNumber and isEmergencyNumber.

Updated linter to include shortnumberinfo related files, and fixed some
lint issues existing with PhoneNumberUtil files.

* ShortNumberInfo functionality and tests ported. Unformatted and missing jsdoc

* Added comments, and fixed as many lint issues as possible.

* lint and comment review comments from andyst addressed.

* Add a golden metadata build test for short number metadata.

* Revert changes to the original phone metadata golden tests.

* Fix a lot of linting and jsdoc typing errors caught by the compiler.

* Add ShortNumberInfo to the javascript demo pages.

* Add ShortNumberIInfo porting to pending_code_changes.

* Add constants to golden tests.

* Update the build tooling

* uUdate pending changes to differentiate build and code changes

* Update build file, fix small test closure compilation issues

* Regenerate short number metadata to account for metadata updates between original generation and now.

* Move requires to alphabetical order

8 years ago

3 Commits (74ec582721c18191fa347d94de087ccc66cef1f0)