libphonenumber

1923 Commits

63 Branches

432 MiB

Tree: b92768990e

Commit Graph

Author	SHA1	Message	Date
James Wright	41a070a207	Add Short Number capabilities to libphonenumber-javascript. (#2122 ) * ShortNumberInfo metadata tooling - add missing fields to generated JSON. Adjust javascript metadata generation tooling to include PhoneMetadata proto fields 29,30,31, and 33 that were previously excluded which are now needed for ShortNumberInfo. * Add shortnumberinfo metadata to build metadata golden tests. * Remove inaccurate comments in build tooling * Add namespace to BuildMetadataJsonFromXml to support tool reuse * Use updated build tooling to generate short number metadata file * update phonemetadata.pb.js to match the current proto definition * remove field 7 from phonemetadata.pb.js * Update build tool to correctly namespacee the generated metadata files * Stop field 32 from being populated as it is not used in the APIs * remove metadata accessors for field 32. * Add tests for connectsToEmergenyNumber and isEmergencyNumber. Updated linter to include shortnumberinfo related files, and fixed some lint issues existing with PhoneNumberUtil files. * ShortNumberInfo functionality and tests ported. Unformatted and missing jsdoc * Added comments, and fixed as many lint issues as possible. * lint and comment review comments from andyst addressed. * Add a golden metadata build test for short number metadata. * Revert changes to the original phone metadata golden tests. * Fix a lot of linting and jsdoc typing errors caught by the compiler. * Add ShortNumberInfo to the javascript demo pages. * Add ShortNumberIInfo porting to pending_code_changes. * Add constants to golden tests. * Update the build tooling * uUdate pending changes to differentiate build and code changes * Update build file, fix small test closure compilation issues * Regenerate short number metadata to account for metadata updates between original generation and now. * Move requires to alphabetical order	8 years ago
lararennie	a11ba762a7	BuildMetadata updates (#1726 ) 1) Changing the BuildMetadataFromXml to only set same_mobile_and_fixed_line_pattern and national_prefix_optional_when_formatting if they differ from default values, and the domestic_carrier_code_formatting_rule, international_prefix and national_prefix_formatting_rule if there is one. 2) Adding a test with some golden data for the BuildMetadataJsonFromXml. 3) Adding to the proto a missing explicit default false. 4) Updating a couple of methods in the Phonemetadata.java class to have names that match those of the auto-generated Phonemetadata used by the CPP build, now that we use those methods when building the metadata. 5) Fix to ant build file to enable the junit command to still work (instructions on open-source on how to regenerate metadata files refer to this) Resulting data is smaller for Java and C++ and the resulting BuildMetadataJsonFromXml code is cleaner.	9 years ago

Author

SHA1

Message

Date

James Wright

41a070a207

Add Short Number capabilities to libphonenumber-javascript. (#2122 )

* ShortNumberInfo metadata tooling - add missing fields to generated JSON.

Adjust javascript metadata generation tooling to include PhoneMetadata proto fields 29,30,31, and 33 that were previously excluded which are now needed for ShortNumberInfo.

* Add shortnumberinfo metadata to build metadata golden tests.

* Remove inaccurate comments in build tooling

* Add namespace to BuildMetadataJsonFromXml to support tool reuse

* Use updated build tooling to generate short number metadata file

* update phonemetadata.pb.js to match the current proto definition

* remove field 7 from phonemetadata.pb.js

* Update build tool to correctly namespacee the generated metadata files

* Stop field 32 from being populated as it is not used in the APIs

* remove metadata accessors for field 32.

* Add tests for connectsToEmergenyNumber and isEmergencyNumber.

Updated linter to include shortnumberinfo related files, and fixed some
lint issues existing with PhoneNumberUtil files.

* ShortNumberInfo functionality and tests ported. Unformatted and missing jsdoc

* Added comments, and fixed as many lint issues as possible.

* lint and comment review comments from andyst addressed.

* Add a golden metadata build test for short number metadata.

* Revert changes to the original phone metadata golden tests.

* Fix a lot of linting and jsdoc typing errors caught by the compiler.

* Add ShortNumberInfo to the javascript demo pages.

* Add ShortNumberIInfo porting to pending_code_changes.

* Add constants to golden tests.

* Update the build tooling

* uUdate pending changes to differentiate build and code changes

* Update build file, fix small test closure compilation issues

* Regenerate short number metadata to account for metadata updates between original generation and now.

* Move requires to alphabetical order

8 years ago

lararennie

a11ba762a7

BuildMetadata updates (#1726 )

1) Changing the BuildMetadataFromXml to only set
same_mobile_and_fixed_line_pattern and
national_prefix_optional_when_formatting if they differ from default
values, and the domestic_carrier_code_formatting_rule,
international_prefix and national_prefix_formatting_rule if there is
one.

2) Adding a test with some golden data for the BuildMetadataJsonFromXml.

3) Adding to the proto a missing explicit default false.

4) Updating a couple of methods in the Phonemetadata.java class to have
names that match those of the auto-generated Phonemetadata used by the
CPP build, now that we use those methods when building the metadata.

5) Fix to ant build file to enable the junit command to still work (instructions on open-source on how to regenerate metadata files refer to this)

Resulting data is smaller for Java and C++ and the resulting BuildMetadataJsonFromXml code is cleaner.

9 years ago

2 Commits (b92768990ec7b9c11fd93fb8a948ddb02fc32614)