- LOGGER -> logger
- Small comment fixes
- Style-guide-recommended formatting changes
- Removal of duplicate, unneeded method in PhoneNumberToTimeZonesMapper.java for canBeGeocoded, using phoneNumberUtil instead.

We remove the dependency on protobuf (protobuf-javanano) from the Java library, resurrecting java/libphonenumber/src/com/google/i18n/phonenumbers/Phonemetadata.java which was present until libphonenumber-7.1.1.

Does not affect the C++ or JavaScript libraries.

https://groups.google.com/forum/#!topic/libphonenumber-discuss/75TOpTFVi08

* Initial code changes to support the new possibleLengths infrastructure
when building metadata. Includes setting these in the main metadata
file and changing the code to populate them in the PhoneMetadata proto
at build time. Updating tests for Java.

* Updating comment about the possible_lengths_local_only field.

* Adding the generated jars that build files containing the new possible
lengths fields.

* Rebuilding short-number metadata with the new proto field. Not doing
this at release time so we can see what changes in the metadata are due
to metadata fixes, rather than this possibleLengths field.

* Regeneration of phone number metadata with the new possible length
information filled in.

Includes some possible length changes for KR and BY, and a validation
fix for NA where a digit was missing.

* Updating the test proto metadata files with the new possible length
information.

* Added notes about the code changes.

* Regenerating C++ metadata with new possibleLength info and updating unit
test to check this works.

Great!

Implicit cast to bool does not work with C++11 and later. See
http://en.cppreference.com/w/cpp/io/basic_ios/operator_bool

Signed-off-by: Gregor Jasny <gjasny@googlemail.com>

Signed-off-by: Gregor Jasny <gjasny@googlemail.com>

cherry-pick of googlei18n/libphonenumber#884

MultiFileMetadataSourceImpl.

The preprocessor expression defined(COMPILER_GCC) is used in code copied
from the Chromium project, but COMPILER_GCC is not defined by GCC itself,
but by the following expression in Chromium's build_config.h:

#if defined(__GNUC__)
#define COMPILER_GCC 1
#elif // ...

It must therefore be changed when copying the code out of the Chromium
code base.

This is a cherry-pick from the Chromium project, from where this
implementation of basictypes.h once originated:

https://chromium.googlesource.com/chromium/src/+/539fc83

- Adds the manifest entries to the basic tools JAR.

- Creates a symlink named like the dependencies JAR that was used
  previously.

- Creates a symlink to the protobuf JAR.

In the manifest, the classpath reference to the protobuf JAR is a
relative filename. The second symbolic link satisfies that by linking to
the installed JAR.

This is only needed for people building packages

People who build normally with Maven will find that "mvn package" still
produces the original tools JAR which has its own Main-Class attribute

Author: daniel@pocock.pro

Normally it is not a good idea to place <version> constraints in the
definition of plugins in pom.xml unless a specific version really is
needed.

This patch removes the constraints.

There are various benefits to this, one of them is that it will always
build with the latest packaged version of the plugins on a Debian or
Ubuntu system.

Author: daniel@pocock.pro

R=jia.shao.peng@gmail.com
BUG=

Review URL: https://codereview.appspot.com/122480043