| Author | SHA1 | Message | Date |
|---|---|---|---|
|
|
d281d59a3c |
Fix javascript build issues (#2425)
Compiling errors found when compiled against new version of closure-compiler >> No warning class for name: ambiguousFunctionDecl >> Same case for: fileoverviewTags google/closure-compiler@04cba67 internetExplorerChecks google/closure-compiler@baab835 >> Moreover, deprecated syntax errors for defineClass "[exec] /Users/lee/ClickToCloud/git/closure-library/closure/goog/base.js:2259: ERROR - [JSC_DEPRECATED_PROP_REASON]" So we have updated the build.xml so that it no more considers these specific issues as errors and block the build/compilation. |
6 years ago |
|
|
257355d846 |
Add Short Number capabilities to libphonenumber-javascript. (#2122)
* ShortNumberInfo metadata tooling - add missing fields to generated JSON. Adjust javascript metadata generation tooling to include PhoneMetadata proto fields 29,30,31, and 33 that were previously excluded which are now needed for ShortNumberInfo. * Add shortnumberinfo metadata to build metadata golden tests. * Remove inaccurate comments in build tooling * Add namespace to BuildMetadataJsonFromXml to support tool reuse * Use updated build tooling to generate short number metadata file * update phonemetadata.pb.js to match the current proto definition * remove field 7 from phonemetadata.pb.js * Update build tool to correctly namespacee the generated metadata files * Stop field 32 from being populated as it is not used in the APIs * remove metadata accessors for field 32. * Add tests for connectsToEmergenyNumber and isEmergencyNumber. Updated linter to include shortnumberinfo related files, and fixed some lint issues existing with PhoneNumberUtil files. * ShortNumberInfo functionality and tests ported. Unformatted and missing jsdoc * Added comments, and fixed as many lint issues as possible. * lint and comment review comments from andyst addressed. * Add a golden metadata build test for short number metadata. * Revert changes to the original phone metadata golden tests. * Fix a lot of linting and jsdoc typing errors caught by the compiler. * Add ShortNumberInfo to the javascript demo pages. * Add ShortNumberIInfo porting to pending_code_changes. * Add constants to golden tests. * Update the build tooling * uUdate pending changes to differentiate build and code changes * Update build file, fix small test closure compilation issues * Regenerate short number metadata to account for metadata updates between original generation and now. * Move requires to alphabetical order |
8 years ago |
|
|
64e4d0ca94 | Regenerate build tools jars with new changes (#1708) | 9 years ago |
|
|
5e637cb1bb |
Adding secret option which *really* catches all missing requires. (#1674)
Tested and it detected goog.object was missing! |
9 years ago |
|
|
8851902ba8 |
Adding two more compilation warnings - extra and missing requires. (#1671)
Added the missing requires this detected, removed the extra require. One missing require was added manually (goog.object) since it's unable to detect it. Updated the readme: compiling everything seems to work at the moment. |
9 years ago |
|
|
0471edf148 |
Modified javascript build instructions and build to use the maven build
for closure compiler: newer versions of the compiler have stopped ant build support. |
9 years ago |
|
|
ae0818a8e5 |
JS: Add build.xml to compile and lint the code. Updated README with instructions how to compile and use the library. Use demo.js and demo-compiled.js as example. Checking in demo-compiled.html and js to be linked from the project home page.
Review URL: https://codereview.appspot.com/8889044 |
13 years ago |