From 003e8651cefbad2ba90594d35a86b350d8974bf9 Mon Sep 17 00:00:00 2001
From: Ross McFarland <ross@github.com>
Date: Tue, 16 Jul 2019 06:14:45 -0700
Subject: [PATCH] Drop dynamic record value weight to 0-16

That's all Dyn supports and it's cleaner to match it than to scale dyn since
we'd lose precision we can't get back during populate.
---
 octodns/record/__init__.py                   | 2 +-
 tests/config/dynamic.tests.yaml              | 6 +++---
 tests/config/split/dynamic.tests./a.yaml     | 2 +-
 tests/config/split/dynamic.tests./cname.yaml | 4 ++--
 tests/test_octodns_record.py                 | 4 ++--
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/octodns/record/__init__.py b/octodns/record/__init__.py
index dca6100..83632bc 100644
--- a/octodns/record/__init__.py
+++ b/octodns/record/__init__.py
@@ -514,7 +514,7 @@ class _DynamicMixin(object):
                     try:
                         weight = value['weight']
                         weight = int(weight)
-                        if weight < 1 or weight > 255:
+                        if weight < 1 or weight > 15:
                             reasons.append('invalid weight "{}" in pool "{}" '
                                            'value {}'.format(weight, _id,
                                                              value_num))
diff --git a/tests/config/dynamic.tests.yaml b/tests/config/dynamic.tests.yaml
index 3d806f9..f826880 100644
--- a/tests/config/dynamic.tests.yaml
+++ b/tests/config/dynamic.tests.yaml
@@ -19,7 +19,7 @@ a:
           - value: 6.6.6.6
             weight: 10
           - value: 5.5.5.5
-            weight: 25
+            weight: 15
     rules:
       - geos:
         - EU-GB
@@ -90,9 +90,9 @@ cname:
       sea:
         values:
           - value: target-sea-1.unit.tests.
-            weight: 100
+            weight: 10
           - value: target-sea-2.unit.tests.
-            weight: 175
+            weight: 14
     rules:
       - geos:
         - EU-GB
diff --git a/tests/config/split/dynamic.tests./a.yaml b/tests/config/split/dynamic.tests./a.yaml
index fd748b4..f182df6 100644
--- a/tests/config/split/dynamic.tests./a.yaml
+++ b/tests/config/split/dynamic.tests./a.yaml
@@ -23,7 +23,7 @@ a:
         fallback: null
         values:
         - value: 5.5.5.5
-          weight: 25
+          weight: 15
         - value: 6.6.6.6
           weight: 10
     rules:
diff --git a/tests/config/split/dynamic.tests./cname.yaml b/tests/config/split/dynamic.tests./cname.yaml
index a84c202..ff85955 100644
--- a/tests/config/split/dynamic.tests./cname.yaml
+++ b/tests/config/split/dynamic.tests./cname.yaml
@@ -21,9 +21,9 @@ cname:
         fallback: null
         values:
         - value: target-sea-1.unit.tests.
-          weight: 100
+          weight: 10
         - value: target-sea-2.unit.tests.
-          weight: 175
+          weight: 14
     rules:
     - geos:
       - EU-GB
diff --git a/tests/test_octodns_record.py b/tests/test_octodns_record.py
index 53bc5e7..2b11364 100644
--- a/tests/test_octodns_record.py
+++ b/tests/test_octodns_record.py
@@ -2460,7 +2460,7 @@ class TestDynamicRecords(TestCase):
                             'weight': 1,
                             'value': '6.6.6.6',
                         }, {
-                            'weight': 256,
+                            'weight': 16,
                             'value': '7.7.7.7',
                         }],
                     },
@@ -2484,7 +2484,7 @@ class TestDynamicRecords(TestCase):
         }
         with self.assertRaises(ValidationError) as ctx:
             Record.new(self.zone, 'bad', a_data)
-        self.assertEquals(['invalid weight "256" in pool "three" value 2'],
+        self.assertEquals(['invalid weight "16" in pool "three" value 2'],
                           ctx.exception.reasons)
 
         # invalid non-int weight