diff --git a/CHANGELOG.md b/CHANGELOG.md index 44209eb..5bf11a4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -162,7 +162,7 @@ unless the `processors` key is present in zone configs. * Fixes NS1 provider's geotarget limitation of using `NA` continent. Now, when `NA` is used in geos it considers **all** the countries of `North America` - insted of just `us-east`, `us-west` and `us-central` regions + instead of just `us-east`, `us-west` and `us-central` regions * `SX' & 'UM` country support added to NS1Provider, not yet in the North America list for backwards compatibility reasons. They will be added in the next releaser. @@ -278,7 +278,7 @@ * AkamaiProvider, ConstellixProvider, MythicBeastsProvider, SelectelProvider, & TransipPovider providers added -* Route53Provider seperator fix +* Route53Provider separator fix * YamlProvider export error around stringification * PyPi markdown rendering fix @@ -351,7 +351,7 @@ Using this version on existing records with `geo` will result in recreating all health checks. This process has been tested pretty thoroughly to -try and ensure a seemless upgrade without any traffic shifting around. It's +try and ensure a seamless upgrade without any traffic shifting around. It's probably best to take extra care when updating and to try and make sure that all health checks are passing before the first sync with `--doit`. See [#67](https://github.com/octodns/octodns/pull/67) for more information. diff --git a/README.md b/README.md index 93ff704..1c88df4 100644 --- a/README.md +++ b/README.md @@ -23,7 +23,7 @@ The architecture is pluggable and the tooling is flexible to make it applicable * [Updating to use extracted providers](#updating-to-use-extracted-providers) - [Sources](#sources) + [Notes](#notes) -- [Compatibilty and Compliance](#compatibilty-and-compliance) +- [Compatibility and Compliance](#compatibilty-and-compliance) * [`lenient`](#-lenient-) * [`strict_supports` (Work In Progress)](#-strict-supports---work-in-progress-) * [Configuring `strict_supports`](#configuring--strict-supports-) @@ -55,7 +55,7 @@ $ mkdir config #### Installing a specific commit SHA -If you'd like to install a version that has not yet been released in a repetable/safe manner you can do the following. In general octoDNS is fairly stable inbetween releases thanks to the plan and apply process, but care should be taken regardless. +If you'd like to install a version that has not yet been released in a repetable/safe manner you can do the following. In general octoDNS is fairly stable in between releases thanks to the plan and apply process, but care should be taken regardless. ```shell $ pip install -e git+https://git@github.com/octodns/octodns.git@#egg=octodns @@ -195,7 +195,7 @@ The above command pulled the existing data out of Route53 and placed the results ## Providers -The table below lists the providers octoDNS supports. They are maintained in their own repositories and released as independant modules. +The table below lists the providers octoDNS supports. They are maintained in their own repositories and released as independent modules. | Provider | Module | Notes | |--|--|--| @@ -250,7 +250,7 @@ Similar to providers, but can only serve to populate records into a zone, cannot * Dnsimple's uses the configured TTL when serving things through the ALIAS, there's also a secondary TXT record created alongside the ALIAS that octoDNS ignores * octoDNS itself supports non-ASCII character sets, but in testing Cloudflare is the only provider where that is currently functional end-to-end. Others have failures either in the client libraries or API calls -## Compatibilty and Compliance +## Compatibility and Compliance ### `lenient` diff --git a/octodns/processor/awsacm.py b/octodns/processor/awsacm.py index 63376fd..f147c00 100644 --- a/octodns/processor/awsacm.py +++ b/octodns/processor/awsacm.py @@ -15,7 +15,7 @@ try: from octodns_route53.processor import AwsAcmMangingProcessor AwsAcmMangingProcessor # pragma: no cover except ModuleNotFoundError: - logger.exception('AwsAcmMangingProcessor has been moved into a seperate ' + logger.exception('AwsAcmMangingProcessor has been moved into a separate ' 'module, octodns_route53 is now required. Processor ' 'class should be updated to ' 'octodns_route53.processor.AwsAcmMangingProcessor') diff --git a/octodns/processor/base.py b/octodns/processor/base.py index 98f2baa..82ee66a 100644 --- a/octodns/processor/base.py +++ b/octodns/processor/base.py @@ -15,7 +15,7 @@ class BaseProcessor(object): ''' Called after all sources have completed populate. Provides an opportunity for the processor to modify the desired `Zone` that targets - will recieve. + will receive. - Will see `desired` after any modifications done by `Provider._process_desired_zone` and processors configured to run diff --git a/octodns/provider/azuredns.py b/octodns/provider/azuredns.py index 4dbf213..3210685 100644 --- a/octodns/provider/azuredns.py +++ b/octodns/provider/azuredns.py @@ -15,7 +15,7 @@ try: from octodns_azure import AzureProvider AzureProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('AzureProvider has been moved into a seperate module, ' + logger.exception('AzureProvider has been moved into a separate module, ' 'octodns_azure is now required. Provider class should ' 'be updated to octodns_azure.AzureProvider. See ' 'https://github.com/octodns/octodns#updating-' diff --git a/octodns/provider/cloudflare.py b/octodns/provider/cloudflare.py index 7e0986f..c1a8f56 100644 --- a/octodns/provider/cloudflare.py +++ b/octodns/provider/cloudflare.py @@ -15,7 +15,7 @@ try: from octodns_cloudflare import CloudflareProvider CloudflareProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('CloudflareProvider has been moved into a seperate ' + logger.exception('CloudflareProvider has been moved into a separate ' 'module, octodns_cloudflare is now required. Provider ' 'class should be updated to ' 'octodns_cloudflare.CloudflareProvider. See ' diff --git a/octodns/provider/constellix.py b/octodns/provider/constellix.py index 76e01ea..5159951 100644 --- a/octodns/provider/constellix.py +++ b/octodns/provider/constellix.py @@ -15,7 +15,7 @@ try: from octodns_constellix import ConstellixProvider ConstellixProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('ConstellixProvider has been moved into a seperate ' + logger.exception('ConstellixProvider has been moved into a separate ' 'module, octodns_constellix is now required. Provider ' 'class should be updated to ' 'octodns_constellix.ConstellixProvider. See ' diff --git a/octodns/provider/digitalocean.py b/octodns/provider/digitalocean.py index d7152ff..9ea59b1 100644 --- a/octodns/provider/digitalocean.py +++ b/octodns/provider/digitalocean.py @@ -15,7 +15,7 @@ try: from octodns_digitalocean import DigitalOceanProvider DigitalOceanProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('DigitalOceanProvider has been moved into a seperate ' + logger.exception('DigitalOceanProvider has been moved into a separate ' 'module, octodns_digitalocean is now required. Provider ' 'class should be updated to ' 'octodns_digitalocean.DigitalOceanProvider. See ' diff --git a/octodns/provider/dnsimple.py b/octodns/provider/dnsimple.py index 7a2a97c..cd379a1 100644 --- a/octodns/provider/dnsimple.py +++ b/octodns/provider/dnsimple.py @@ -15,7 +15,7 @@ try: from octodns_dnsimple import DnsimpleProvider DnsimpleProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('DnsimpleProvider has been moved into a seperate module, ' + logger.exception('DnsimpleProvider has been moved into a separate module, ' 'octodns_dnsimple is now required. Provider class should ' 'be updated to octodns_dnsimple.DnsimpleProvider. See ' 'https://github.com/octodns/octodns#updating-' diff --git a/octodns/provider/dnsmadeeasy.py b/octodns/provider/dnsmadeeasy.py index 459767a..fc54c38 100644 --- a/octodns/provider/dnsmadeeasy.py +++ b/octodns/provider/dnsmadeeasy.py @@ -15,7 +15,7 @@ try: from octodns_dnsmadeeasy import DnsMadeEasyProvider DnsMadeEasyProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('DnsMadeEasyProvider has been moved into a seperate ' + logger.exception('DnsMadeEasyProvider has been moved into a separate ' 'module, octodns_dnsmadeeasy is now required. Provider ' 'class should be updated to ' 'octodns_dnsmadeeasy.DnsMadeEasyProvider. See ' diff --git a/octodns/provider/dyn.py b/octodns/provider/dyn.py index befb1e3..eef3a7a 100644 --- a/octodns/provider/dyn.py +++ b/octodns/provider/dyn.py @@ -15,7 +15,7 @@ try: from octodns_dyn import DynProvider DynProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('DynProvider has been moved into a seperate module, ' + logger.exception('DynProvider has been moved into a separate module, ' 'octodns_dyn is now required. Provider class should ' 'be updated to octodns_dyn.DynProvider. See ' 'https://github.com/octodns/octodns#updating-' diff --git a/octodns/provider/easydns.py b/octodns/provider/easydns.py index 5f78570..7be551b 100644 --- a/octodns/provider/easydns.py +++ b/octodns/provider/easydns.py @@ -16,7 +16,7 @@ try: EasyDnsProvider # pragma: no cover EasyDNSProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('EasyDNSProvider has been moved into a seperate module, ' + logger.exception('EasyDNSProvider has been moved into a separate module, ' 'octodns_easydns is now required. Provider class should ' 'be updated to octodns_easydns.EasyDnsProvider. See ' 'https://github.com/octodns/octodns#updating-' diff --git a/octodns/provider/edgedns.py b/octodns/provider/edgedns.py index 020f7c3..8e1e58c 100644 --- a/octodns/provider/edgedns.py +++ b/octodns/provider/edgedns.py @@ -15,7 +15,7 @@ try: from octodns_edgedns import AkamaiProvider AkamaiProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('AkamaiProvider has been moved into a seperate module, ' + logger.exception('AkamaiProvider has been moved into a separate module, ' 'octodns_edgedns is now required. Provider class should ' 'be updated to octodns_edgedns.AkamaiProvider. See ' 'https://github.com/octodns/octodns#updating-' diff --git a/octodns/provider/etc_hosts.py b/octodns/provider/etc_hosts.py index 9f02988..4ae9ee9 100644 --- a/octodns/provider/etc_hosts.py +++ b/octodns/provider/etc_hosts.py @@ -15,7 +15,7 @@ try: from octodns_etchosts import EtcHostsProvider EtcHostsProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('EtcHostsProvider has been moved into a seperate module, ' + logger.exception('EtcHostsProvider has been moved into a separate module, ' 'octodns_etchosts is now required. Provider class should ' 'be updated to octodns_etchosts.EtcHostsProvider. See ' 'See https://github.com/octodns/octodns#updating-' diff --git a/octodns/provider/fastdns.py b/octodns/provider/fastdns.py index f795d40..9dd1490 100644 --- a/octodns/provider/fastdns.py +++ b/octodns/provider/fastdns.py @@ -8,7 +8,7 @@ from __future__ import absolute_import, division, print_function, \ from logging import getLogger logger = getLogger('Akamai') -logger.warning('AkamaiProvider has been moved into a seperate module, ' +logger.warning('AkamaiProvider has been moved into a separate module, ' 'octodns_edgedns is now required. Provider class should ' 'be updated to octodns_edgedns.AkamaiProvider. See ' 'https://github.com/octodns/octodns#updating-' diff --git a/octodns/provider/gandi.py b/octodns/provider/gandi.py index 121bdd4..2429bfa 100644 --- a/octodns/provider/gandi.py +++ b/octodns/provider/gandi.py @@ -15,7 +15,7 @@ try: from octodns_gandi import GandiProvider GandiProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('GandiProvider has been moved into a seperate module, ' + logger.exception('GandiProvider has been moved into a separate module, ' 'octodns_gandi is now required. Provider class should ' 'be updated to octodns_gandi.GandiProvider. See ' 'https://github.com/octodns/octodns#updating-' diff --git a/octodns/provider/gcore.py b/octodns/provider/gcore.py index 83b3dd3..141ed10 100644 --- a/octodns/provider/gcore.py +++ b/octodns/provider/gcore.py @@ -15,7 +15,7 @@ try: from octodns_gcore import GCoreProvider GCoreProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('GCoreProvider has been moved into a seperate module, ' + logger.exception('GCoreProvider has been moved into a separate module, ' 'octodns_gcore is now required. Provider class should ' 'be updated to octodns_gcore.GCoreProvider. See ' 'https://github.com/octodns/octodns#updating-' diff --git a/octodns/provider/googlecloud.py b/octodns/provider/googlecloud.py index e997533..22cb07a 100644 --- a/octodns/provider/googlecloud.py +++ b/octodns/provider/googlecloud.py @@ -15,7 +15,7 @@ try: from octodns_googlecloud import GoogleCloudProvider GoogleCloudProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('GoogleCloudProvider has been moved into a seperate ' + logger.exception('GoogleCloudProvider has been moved into a separate ' 'module, octodns_googlecloud is now required. Provider ' 'class should be updated to ' 'octodns_googlecloud.GoogleCloudProvider. See ' diff --git a/octodns/provider/hetzner.py b/octodns/provider/hetzner.py index 78603c7..38577e4 100644 --- a/octodns/provider/hetzner.py +++ b/octodns/provider/hetzner.py @@ -15,7 +15,7 @@ try: from octodns_hetzner import HetznerProvider HetznerProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('HetznerProvider has been moved into a seperate module, ' + logger.exception('HetznerProvider has been moved into a separate module, ' 'octodns_hetzner is now required. Provider class should ' 'be updated to octodns_hetzner.HetznerProvider. See ' 'https://github.com/octodns/octodns#updating-' diff --git a/octodns/provider/mythicbeasts.py b/octodns/provider/mythicbeasts.py index d9eed8a..0d1378e 100644 --- a/octodns/provider/mythicbeasts.py +++ b/octodns/provider/mythicbeasts.py @@ -15,7 +15,7 @@ try: from octodns_mythicbeasts import MythicBeastsProvider MythicBeastsProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('MythicBeastsProvider has been moved into a seperate ' + logger.exception('MythicBeastsProvider has been moved into a separate ' 'module, octodns_mythicbeasts is now required. Provider ' 'class should be updated to ' 'octodns_mythicbeasts.MythicBeastsProvider. See ' diff --git a/octodns/provider/ns1.py b/octodns/provider/ns1.py index 79f9252..76398a8 100644 --- a/octodns/provider/ns1.py +++ b/octodns/provider/ns1.py @@ -15,7 +15,7 @@ try: from octodns_ns1 import Ns1Provider Ns1Provider # pragma: no cover except ModuleNotFoundError: - logger.exception('Ns1Provider has been moved into a seperate module, ' + logger.exception('Ns1Provider has been moved into a separate module, ' 'octodns_ns1 is now required. Provider class should ' 'be updated to octodns_ns1.Ns1Provider. See ' 'https://github.com/octodns/octodns#updating-' diff --git a/octodns/provider/ovh.py b/octodns/provider/ovh.py index 6147c57..5f83560 100644 --- a/octodns/provider/ovh.py +++ b/octodns/provider/ovh.py @@ -15,7 +15,7 @@ try: from octodns_ovh import OvhProvider OvhProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('OvhProvider has been moved into a seperate module, ' + logger.exception('OvhProvider has been moved into a separate module, ' 'octodns_ovh is now required. Provider class should ' 'be updated to octodns_ovh.OvhProvider. See ' 'https://github.com/octodns/octodns#updating-' diff --git a/octodns/provider/powerdns.py b/octodns/provider/powerdns.py index cb52c6d..7a28f46 100644 --- a/octodns/provider/powerdns.py +++ b/octodns/provider/powerdns.py @@ -16,7 +16,7 @@ try: PowerDnsProvider # pragma: no cover PowerDnsBaseProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('PowerDnsProvider has been moved into a seperate module, ' + logger.exception('PowerDnsProvider has been moved into a separate module, ' 'octodns_powerdns is now required. Provider class should ' 'be updated to octodns_powerdns.PowerDnsProvider. See ' 'https://github.com/octodns/octodns#updating-' diff --git a/octodns/provider/rackspace.py b/octodns/provider/rackspace.py index 586fd5b..77436be 100644 --- a/octodns/provider/rackspace.py +++ b/octodns/provider/rackspace.py @@ -15,7 +15,7 @@ try: from octodns_rackspace import RackspaceProvider RackspaceProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('RackspaceProvider has been moved into a seperate ' + logger.exception('RackspaceProvider has been moved into a separate ' 'module, octodns_rackspace is now required. Provider ' 'class should be updated to ' 'octodns_rackspace.RackspaceProvider. See ' diff --git a/octodns/provider/route53.py b/octodns/provider/route53.py index 9d5f42a..744281e 100644 --- a/octodns/provider/route53.py +++ b/octodns/provider/route53.py @@ -15,7 +15,7 @@ try: from octodns_route53 import Route53Provider Route53Provider # pragma: no cover except ModuleNotFoundError: - logger.exception('Route53Provider has been moved into a seperate module, ' + logger.exception('Route53Provider has been moved into a separate module, ' 'octodns_route53 is now required. Provider class should ' 'be updated to octodns_route53.Route53Provider. See ' 'https://github.com/octodns/octodns#updating-' diff --git a/octodns/provider/selectel.py b/octodns/provider/selectel.py index 4728a75..44325db 100644 --- a/octodns/provider/selectel.py +++ b/octodns/provider/selectel.py @@ -15,7 +15,7 @@ try: from octodns_selectel import SelectelProvider SelectelProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('SelectelProvider has been moved into a seperate module, ' + logger.exception('SelectelProvider has been moved into a separate module, ' 'octodns_selectel is now required. Provider class should ' 'be updated to octodns_selectel.SelectelProvider. See ' 'https://github.com/octodns/octodns#updating-' diff --git a/octodns/provider/transip.py b/octodns/provider/transip.py index 278aeff..5282b42 100644 --- a/octodns/provider/transip.py +++ b/octodns/provider/transip.py @@ -15,7 +15,7 @@ try: from octodns_transip import TransipProvider TransipProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('TransipProvider has been moved into a seperate module, ' + logger.exception('TransipProvider has been moved into a separate module, ' 'octodns_transip is now required. Provider class should ' 'be updated to octodns_transip.TransipProvider. See ' 'https://github.com/octodns/octodns#updating-' diff --git a/octodns/provider/ultra.py b/octodns/provider/ultra.py index 51c388b..6ccaf7a 100644 --- a/octodns/provider/ultra.py +++ b/octodns/provider/ultra.py @@ -15,7 +15,7 @@ try: from octodns_ultra import UltraProvider UltraProvider # pragma: no cover except ModuleNotFoundError: - logger.exception('UltraProvider has been moved into a seperate module, ' + logger.exception('UltraProvider has been moved into a separate module, ' 'octodns_ultra is now required. Provider class should ' 'be updated to octodns_ultra.UltraProvider. See ' 'https://github.com/octodns/octodns#updating-' diff --git a/octodns/source/base.py b/octodns/source/base.py index dfc1613..e328b04 100644 --- a/octodns/source/base.py +++ b/octodns/source/base.py @@ -38,7 +38,7 @@ class BaseSource(object): When `lenient` is True the populate call may skip record validation and do a "best effort" load of data. That will allow through some common, but not best practices stuff that we otherwise would reject. E.g. no - trailing . or mising escapes for ;. + trailing . or missing escapes for ;. When target is True (loading current state) this method should return True if the zone exists or False if it does not. diff --git a/tests/test_octodns_manager.py b/tests/test_octodns_manager.py index 6d85924..1c01af9 100644 --- a/tests/test_octodns_manager.py +++ b/tests/test_octodns_manager.py @@ -290,7 +290,7 @@ class TestManager(TestCase): manager.dump('unit.tests.', tmpdir.dirname, False, False, 'in') # make sure this fails with an IOError and not a KeyError when - # tyring to find sub zones + # trying to find sub zones with self.assertRaises(IOError): manager.dump('unknown.zone.', tmpdir.dirname, False, False, 'in') @@ -319,7 +319,7 @@ class TestManager(TestCase): manager.dump('unit.tests.', tmpdir.dirname, False, True, 'in') # make sure this fails with an OSError and not a KeyError when - # tyring to find sub zones + # trying to find sub zones with self.assertRaises(OSError): manager.dump('unknown.zone.', tmpdir.dirname, False, True, 'in') @@ -447,7 +447,7 @@ class TestManager(TestCase): manager.sync(['unit.tests.']) with self.assertRaises(ManagerException) as ctx: - # This zone specifies a non-existant processor + # This zone specifies a non-existent processor manager.sync(['bad.unit.tests.']) self.assertTrue('Zone bad.unit.tests., unknown processor: ' 'doesnt-exist' in str(ctx.exception)) diff --git a/tests/test_octodns_provider_base.py b/tests/test_octodns_provider_base.py index 398e300..e1140c5 100644 --- a/tests/test_octodns_provider_base.py +++ b/tests/test_octodns_provider_base.py @@ -744,13 +744,13 @@ class TestBaseProviderSupportsRootNs(TestCase): # different root is in the desired plan = provider.plan(self.has_root) - # the mis-match doesn't matter since we can't manage the records + # the mismatch doesn't matter since we can't manage the records # anyway, they will have been removed from the desired and existing. self.assertFalse(plan) # plan again with strict_supports enabled, we should get an exception # b/c we have something configured that can't be managed (doesn't - # matter that it's a mis-match) + # matter that it's a mismatch) provider.strict_supports = True with self.assertRaises(SupportsException) as ctx: provider.plan(self.has_root) @@ -765,7 +765,7 @@ class TestBaseProviderSupportsRootNs(TestCase): # desired doesn't have a root plan = provider.plan(self.no_root) - # the mis-match doesn't matter since we can't manage the records + # the mismatch doesn't matter since we can't manage the records # anyway, they will have been removed from the desired and existing. self.assertFalse(plan) diff --git a/tests/test_octodns_record.py b/tests/test_octodns_record.py index a406d96..4649745 100644 --- a/tests/test_octodns_record.py +++ b/tests/test_octodns_record.py @@ -1759,7 +1759,7 @@ class TestRecordValidation(TestCase): reason = ctx.exception.reasons[0] self.assertTrue(reason.startswith('invalid name "@", use "" instead')) - # fqdn length, DNS defins max as 253 + # fqdn length, DNS defines max as 253 with self.assertRaises(ValidationError) as ctx: # The . will put this over the edge name = 'x' * (253 - len(self.zone.name))