From 0d9ec583b5549cf6feb6d42d307619c9c3aa2aaf Mon Sep 17 00:00:00 2001 From: Mathurin Gagnon <91029118+mtgagnon@users.noreply.github.com> Date: Mon, 28 Apr 2025 14:47:20 -0700 Subject: [PATCH] changed try except to elif and else, updated log line to octodns standard --- octodns/processor/filter.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/octodns/processor/filter.py b/octodns/processor/filter.py index 5619b1c..638823d 100644 --- a/octodns/processor/filter.py +++ b/octodns/processor/filter.py @@ -233,13 +233,13 @@ class _ValueBaseFilter(_FilterProcessor): values = [] if hasattr(record, 'values'): values = [value.rdata_text for value in record.values] + elif record.value is not None: + values = [record.value.rdata_text] else: - try: - values = [record.value.rdata_text] - except AttributeError: - self.log.warning( - f"Value processor ignoring record, value is NoneType: {record.fqdn}" - ) + self.log.warning( + 'value for %s is NoneType, ignoring', record.fqdn + ) + if any(value in self.exact for value in values): self.matches(zone, record) continue