From 11118efe93aa87d6ccd166b48c44d6a07aeebbaa Mon Sep 17 00:00:00 2001 From: Viranch Mehta Date: Mon, 18 Sep 2023 21:41:44 -0700 Subject: [PATCH] Raise exception when no yamls are found for a zone --- octodns/provider/yaml.py | 4 +--- tests/test_octodns_provider_yaml.py | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/octodns/provider/yaml.py b/octodns/provider/yaml.py index 50a4c3a..23e65ef 100644 --- a/octodns/provider/yaml.py +++ b/octodns/provider/yaml.py @@ -353,9 +353,7 @@ class YamlProvider(BaseProvider): sources.append(join(self.directory, self.shared_filename)) if not sources: - self.log.info( - 'populate: no YAMLs found for %s', zone.decoded_name - ) + raise ProviderException(f'no YAMLs found for {zone.decoded_name}') # determinstically order our sources sources.sort() diff --git a/tests/test_octodns_provider_yaml.py b/tests/test_octodns_provider_yaml.py index 901819a..b98c067 100644 --- a/tests/test_octodns_provider_yaml.py +++ b/tests/test_octodns_provider_yaml.py @@ -663,8 +663,8 @@ class TestSplitYamlProvider(TestCase): zone = Zone('empty.', []) # without it we see everything - source.populate(zone) - self.assertEqual(0, len(zone.records)) + with self.assertRaises(ProviderException): + source.populate(zone) def test_unsorted(self): source = SplitYamlProvider(