Browse Source

Avoid double existing_records lookup

pull/518/head
Ross McFarland 6 years ago
committed by GitHub
parent
commit
1fb4f4facd
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
  1. +2
    -3
      octodns/provider/cloudflare.py

+ 2
- 3
octodns/provider/cloudflare.py View File

@ -585,13 +585,12 @@ class CloudflareProvider(BaseProvider):
changed_records = {c.record for c in changes}
for desired_record in desired.records:
if desired_record not in existing_records: # Will be created
existing_record = existing_records.get(desired_record, None)
if existing_record: # Will be created
continue
elif desired_record in changed_records: # Already being updated
continue
existing_record = existing_records[desired_record]
if (self._record_is_proxied(existing_record) !=
self._record_is_proxied(desired_record)):
extra_changes.append(Update(existing_record, desired_record))


Loading…
Cancel
Save