RuhNetConsulting
/
octodns
mirror of https://github.com/octodns/octodns
1
0
Fork 0
Code Issues 0 Projects 0 Releases 52 Wiki Activity
Browse Source

SVCB: rename variables to RFC names

pull/1176/head
Pieter Lexis 2 years ago
parent
f02f94e4ad
commit
23cc45dad9
No known key found for this signature in database GPG Key ID: B6ED640F21BF69E3
2 changed files with 178 additions and 143 deletions
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. +54
    -54
      octodns/record/svcb.py
  2. +124
    -89
      tests/test_octodns_record_svcb.py

+ 54
- 54
octodns/record/svcb.py View File

@ -92,6 +92,7 @@ def validate_svckey_number(paramkey):
return [] return []
# cc https://datatracker.ietf.org/doc/html/rfc9460#keys
SUPPORTED_PARAMS = { SUPPORTED_PARAMS = {
'no-default-alpn': {'has_arg': False}, 'no-default-alpn': {'has_arg': False},
'alpn': {'validate': validate_svcparam_alpn}, 'alpn': {'validate': validate_svcparam_alpn},
@ -108,53 +109,55 @@ class SvcbValue(EqualityTupleMixin, dict):
@classmethod @classmethod
def parse_rdata_text(cls, value): def parse_rdata_text(cls, value):
try: try:
# XXX: these are called SvcPriority, TargetName, and SvcParams in RFC 9460 section 2.
# Should we mirror these names, or are priority, target and params good enough?
# XXX: Should we split params into the specific ParamKeys and ParamValues? # XXX: Should we split params into the specific ParamKeys and ParamValues?
(priority, target, *params) = value.split(' ')
(svcpriority, targetname, *svcparams) = value.split(' ')
except ValueError: except ValueError:
raise RrParseError() raise RrParseError()
try: try:
priority = int(priority)
svcpriority = int(svcpriority)
except ValueError: except ValueError:
pass pass
target = unquote(target)
return {'priority': priority, 'target': target, 'params': params}
targetname = unquote(targetname)
return {
'svcpriority': svcpriority,
'targetname': targetname,
'svcparams': svcparams,
}
@classmethod @classmethod
def validate(cls, data, _): def validate(cls, data, _):
reasons = [] reasons = []
for value in data: for value in data:
priority = -1
if 'priority' not in value:
reasons.append('missing priority')
svcpriority = -1
if 'svcpriority' not in value:
reasons.append('missing svcpriority')
else: else:
try: try:
priority = int(value.get('priority', 0))
if priority < 0 or priority > 65535:
reasons.append(f'invalid priority ' f'"{priority}"')
svcpriority = int(value.get('svcpriority', 0))
if svcpriority < 0 or svcpriority > 65535:
reasons.append(f'invalid priority ' f'"{svcpriority}"')
except ValueError: except ValueError:
reasons.append(
f'invalid priority ' f'"{value["priority"]}"'
)
reasons.append(f'invalid priority "{value["svcpriority"]}"')
if 'target' not in value or value['target'] == '':
reasons.append('missing target')
if 'targetname' not in value or value['targetname'] == '':
reasons.append('missing targetname')
else: else:
target = str(value.get('target', ''))
target = idna_encode(target)
if not target.endswith('.'):
reasons.append(f'SVCB value "{target}" missing trailing .')
if target != '.' and not FQDN(target).is_valid:
targetname = str(value.get('targetname', ''))
targetname = idna_encode(targetname)
if not targetname.endswith('.'):
reasons.append( reasons.append(
f'Invalid SVCB target "{target}" is not a valid FQDN.'
f'SVCB value "{targetname}" missing trailing .'
)
if targetname != '.' and not FQDN(targetname).is_valid:
reasons.append(
f'Invalid SVCB target "{targetname}" is not a valid FQDN.'
) )
if 'params' in value:
params = value.get('params', list())
if priority == 0 and len(params) != 0:
reasons.append('params set on AliasMode SVCB record')
for param in params:
if 'svcparams' in value:
svcparams = value.get('svcparams', list())
if svcpriority == 0 and len(svcparams) != 0:
reasons.append('svcparams set on AliasMode SVCB record')
for param in svcparams:
# XXX: Should we test for keys existing when set in 'mandatory'? # XXX: Should we test for keys existing when set in 'mandatory'?
paramkey, *paramvalue = param.split('=') paramkey, *paramvalue = param.split('=')
if paramkey.startswith('key'): if paramkey.startswith('key'):
@ -187,54 +190,51 @@ class SvcbValue(EqualityTupleMixin, dict):
def __init__(self, value): def __init__(self, value):
super().__init__( super().__init__(
{ {
'priority': int(value['priority']),
'target': idna_encode(value['target']),
'params': value.get('params', list()),
'svcpriority': int(value['svcpriority']),
'targetname': idna_encode(value['targetname']),
'svcparams': value.get('svcparams', list()),
} }
) )
@property @property
def priority(self):
return self['priority']
def svcpriority(self):
return self['svcpriority']
@priority.setter
def priority(self, value):
self['priority'] = value
@svcpriority.setter
def svcpriority(self, value):
self['svcpriority'] = value
@property @property
def target(self):
return self['target']
def targetname(self):
return self['targetname']
@target.setter
def target(self, value):
self['target'] = value
@targetname.setter
def targetname(self, value):
self['targetname'] = value
@property @property
def params(self):
return self['params']
def svcparams(self):
return self['svcparams']
@params.setter
def params(self, value):
self['params'] = value
@svcparams.setter
def svcparams(self, value):
self['svcparams'] = value
@property @property
def rdata_text(self): def rdata_text(self):
params = '' params = ''
if len(self.params) != 0:
params = f' {" ".join(self.params)}'
return f'{self.priority} {self.target}{params}'
if len(self.svcparams) != 0:
params = f' {" ".join(self.svcparams)}'
return f'{self.svcpriority} {self.targetname}{params}'
def __hash__(self): def __hash__(self):
return hash(self.__repr__()) return hash(self.__repr__())
def _equality_tuple(self): def _equality_tuple(self):
return (self.priority, self.target, self.params)
return (self.svcpriority, self.targetname, self.svcparams)
def __repr__(self): def __repr__(self):
params = ''
if len(self.params) != 0:
params = f' {" ".join(self.params)}'
return f"'{self.priority} {self.target}{params}'"
return f"'{self.rdata_text}'"
class SvcbRecord(ValuesMixin, Record): class SvcbRecord(ValuesMixin, Record):


+ 124
- 89
tests/test_octodns_record_svcb.py View File

@ -18,31 +18,33 @@ class TestRecordSvcb(TestCase):
def test_svcb(self): def test_svcb(self):
aliasmode_value = SvcbValue( aliasmode_value = SvcbValue(
{'priority': 0, 'target': 'foo.example.com.'}
{'svcpriority': 0, 'targetname': 'foo.example.com.'}
) )
aliasmode_data = {'ttl': 300, 'value': aliasmode_value} aliasmode_data = {'ttl': 300, 'value': aliasmode_value}
a = SvcbRecord(self.zone, 'alias', aliasmode_data) a = SvcbRecord(self.zone, 'alias', aliasmode_data)
self.assertEqual('alias', a.name) self.assertEqual('alias', a.name)
self.assertEqual('alias.unit.tests.', a.fqdn) self.assertEqual('alias.unit.tests.', a.fqdn)
self.assertEqual(300, a.ttl) self.assertEqual(300, a.ttl)
self.assertEqual(aliasmode_value['priority'], a.values[0].priority)
self.assertEqual(aliasmode_value['target'], a.values[0].target)
self.assertEqual(aliasmode_value['params'], a.values[0].params)
self.assertEqual(
aliasmode_value['svcpriority'], a.values[0].svcpriority
)
self.assertEqual(aliasmode_value['targetname'], a.values[0].targetname)
self.assertEqual(aliasmode_value['svcparams'], a.values[0].svcparams)
self.assertEqual(aliasmode_data, a.data) self.assertEqual(aliasmode_data, a.data)
servicemode_values = [ servicemode_values = [
SvcbValue( SvcbValue(
{ {
'priority': 1,
'target': 'foo.example.com.',
'params': 'port=8002',
'svcpriority': 1,
'targetname': 'foo.example.com.',
'svcparams': 'port=8002',
} }
), ),
SvcbValue( SvcbValue(
{ {
'priority': 2,
'target': 'foo.example.net.',
'params': 'port=8080',
'svcpriority': 2,
'targetname': 'foo.example.net.',
'svcparams': 'port=8080',
} }
), ),
] ]
@ -52,15 +54,23 @@ class TestRecordSvcb(TestCase):
self.assertEqual('service.unit.tests.', b.fqdn) self.assertEqual('service.unit.tests.', b.fqdn)
self.assertEqual(300, b.ttl) self.assertEqual(300, b.ttl)
self.assertEqual( self.assertEqual(
servicemode_values[0]['priority'], b.values[0].priority
servicemode_values[0]['svcpriority'], b.values[0].svcpriority
)
self.assertEqual(
servicemode_values[0]['targetname'], b.values[0].targetname
)
self.assertEqual(
servicemode_values[0]['svcparams'], b.values[0].svcparams
) )
self.assertEqual(servicemode_values[0]['target'], b.values[0].target)
self.assertEqual(servicemode_values[0]['params'], b.values[0].params)
self.assertEqual( self.assertEqual(
servicemode_values[1]['priority'], b.values[1].priority
servicemode_values[1]['svcpriority'], b.values[1].svcpriority
)
self.assertEqual(
servicemode_values[1]['targetname'], b.values[1].targetname
)
self.assertEqual(
servicemode_values[1]['svcparams'], b.values[1].svcparams
) )
self.assertEqual(servicemode_values[1]['target'], b.values[1].target)
self.assertEqual(servicemode_values[1]['params'], b.values[1].params)
self.assertEqual(servicemode_data, b.data) self.assertEqual(servicemode_data, b.data)
target = SimpleProvider() target = SimpleProvider()
@ -70,19 +80,19 @@ class TestRecordSvcb(TestCase):
other = SvcbRecord( other = SvcbRecord(
self.zone, 'service2', {'ttl': 30, 'values': servicemode_values} self.zone, 'service2', {'ttl': 30, 'values': servicemode_values}
) )
other.values[0].priority = 22
other.values[0].svcpriority = 22
change = b.changes(other, target) change = b.changes(other, target)
self.assertEqual(change.existing, b) self.assertEqual(change.existing, b)
self.assertEqual(change.new, other) self.assertEqual(change.new, other)
# Diff in target causes change # Diff in target causes change
other.values[0].priority = b.values[0].priority
other.values[0].target = 'blabla.example.com'
other.values[0].svcpriority = b.values[0].svcpriority
other.values[0].targetname = 'blabla.example.com'
change = b.changes(other, target) change = b.changes(other, target)
self.assertEqual(change.existing, b) self.assertEqual(change.existing, b)
self.assertEqual(change.new, other) self.assertEqual(change.new, other)
# Diff in params causes change # Diff in params causes change
other.values[0].target = b.values[0].target
other.values[0].params = 'port=8888'
other.values[0].targetname = b.values[0].targetname
other.values[0].svcparams = 'port=8888'
change = b.changes(other, target) change = b.changes(other, target)
self.assertEqual(change.existing, b) self.assertEqual(change.existing, b)
self.assertEqual(change.new, other) self.assertEqual(change.new, other)
@ -102,23 +112,31 @@ class TestRecordSvcb(TestCase):
# priority not int # priority not int
self.assertEqual( self.assertEqual(
{'priority': 'one', 'target': 'foo.example.com', 'params': list()},
{
'svcpriority': 'one',
'targetname': 'foo.example.com',
'svcparams': list(),
},
SvcbValue.parse_rdata_text('one foo.example.com'), SvcbValue.parse_rdata_text('one foo.example.com'),
) )
# valid with params # valid with params
self.assertEqual( self.assertEqual(
{ {
'priority': 1,
'target': 'svcb.unit.tests.',
'params': ['port=8080'],
'svcpriority': 1,
'targetname': 'svcb.unit.tests.',
'svcparams': ['port=8080'],
}, },
SvcbValue.parse_rdata_text('1 svcb.unit.tests. port=8080'), SvcbValue.parse_rdata_text('1 svcb.unit.tests. port=8080'),
) )
# quoted target # quoted target
self.assertEqual( self.assertEqual(
{'priority': 1, 'target': 'svcb.unit.tests.', 'params': list()},
{
'svcpriority': 1,
'targetname': 'svcb.unit.tests.',
'svcparams': list(),
},
SvcbValue.parse_rdata_text('1 "svcb.unit.tests."'), SvcbValue.parse_rdata_text('1 "svcb.unit.tests."'),
) )
@ -129,15 +147,15 @@ class TestRecordSvcb(TestCase):
{ {
'ttl': 32, 'ttl': 32,
'value': { 'value': {
'priority': 1,
'target': 'svcb.unit.tests.',
'params': ['port=8080'],
'svcpriority': 1,
'targetname': 'svcb.unit.tests.',
'svcparams': ['port=8080'],
}, },
}, },
) )
self.assertEqual(1, a.values[0].priority)
self.assertEqual('svcb.unit.tests.', a.values[0].target)
self.assertEqual(['port=8080'], a.values[0].params)
self.assertEqual(1, a.values[0].svcpriority)
self.assertEqual('svcb.unit.tests.', a.values[0].targetname)
self.assertEqual(['port=8080'], a.values[0].svcparams)
# both directions should match # both directions should match
rdata = '1 svcb.unit.tests. port=8080' rdata = '1 svcb.unit.tests. port=8080'
@ -154,20 +172,28 @@ class TestRecordSvcb(TestCase):
self.assertEqual(rdata, record.values[0].rdata_text) self.assertEqual(rdata, record.values[0].rdata_text)
def test_svcb_value(self): def test_svcb_value(self):
a = SvcbValue({'priority': 0, 'target': 'foo.', 'params': list()})
b = SvcbValue({'priority': 1, 'target': 'foo.', 'params': list()})
a = SvcbValue(
{'svcpriority': 0, 'targetname': 'foo.', 'svcparams': list()}
)
b = SvcbValue(
{'svcpriority': 1, 'targetname': 'foo.', 'svcparams': list()}
)
c = SvcbValue( c = SvcbValue(
{'priority': 0, 'target': 'foo.', 'params': ['port=8080']}
{'svcpriority': 0, 'targetname': 'foo.', 'svcparams': ['port=8080']}
) )
d = SvcbValue( d = SvcbValue(
{ {
'priority': 0,
'target': 'foo.',
'params': ['alpn=h2,h3', 'port=8080'],
'svcpriority': 0,
'targetname': 'foo.',
'svcparams': ['alpn=h2,h3', 'port=8080'],
} }
) )
e = SvcbValue( e = SvcbValue(
{'priority': 0, 'target': 'mmm.', 'params': ['ipv4hint=192.0.2.1']}
{
'svcpriority': 0,
'targetname': 'mmm.',
'svcparams': ['ipv4hint=192.0.2.1'],
}
) )
self.assertEqual(a, a) self.assertEqual(a, a)
@ -237,7 +263,7 @@ class TestRecordSvcb(TestCase):
{ {
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': {'priority': 1, 'target': 'foo.bar.baz.'},
'value': {'svcpriority': 1, 'targetname': 'foo.bar.baz.'},
}, },
) )
@ -248,7 +274,7 @@ class TestRecordSvcb(TestCase):
{ {
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': {'priority': 1, 'target': 'foo.bar.baz.'},
'value': {'svcpriority': 1, 'targetname': 'foo.bar.baz.'},
}, },
) )
@ -260,10 +286,10 @@ class TestRecordSvcb(TestCase):
{ {
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': {'target': 'foo.bar.baz.'},
'value': {'targetname': 'foo.bar.baz.'},
}, },
) )
self.assertEqual(['missing priority'], ctx.exception.reasons)
self.assertEqual(['missing svcpriority'], ctx.exception.reasons)
# invalid priority # invalid priority
with self.assertRaises(ValidationError) as ctx: with self.assertRaises(ValidationError) as ctx:
@ -273,7 +299,10 @@ class TestRecordSvcb(TestCase):
{ {
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': {'priority': 'foo', 'target': 'foo.bar.baz.'},
'value': {
'svcpriority': 'foo',
'targetname': 'foo.bar.baz.',
},
}, },
) )
self.assertEqual(['invalid priority "foo"'], ctx.exception.reasons) self.assertEqual(['invalid priority "foo"'], ctx.exception.reasons)
@ -286,7 +315,10 @@ class TestRecordSvcb(TestCase):
{ {
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': {'priority': 100000, 'target': 'foo.bar.baz.'},
'value': {
'svcpriority': 100000,
'targetname': 'foo.bar.baz.',
},
}, },
) )
self.assertEqual(['invalid priority "100000"'], ctx.exception.reasons) self.assertEqual(['invalid priority "100000"'], ctx.exception.reasons)
@ -296,9 +328,9 @@ class TestRecordSvcb(TestCase):
Record.new( Record.new(
self.zone, self.zone,
'foo', 'foo',
{'type': 'SVCB', 'ttl': 600, 'value': {'priority': 1}},
{'type': 'SVCB', 'ttl': 600, 'value': {'svcpriority': 1}},
) )
self.assertEqual(['missing target'], ctx.exception.reasons)
self.assertEqual(['missing targetname'], ctx.exception.reasons)
# invalid target # invalid target
with self.assertRaises(ValidationError) as ctx: with self.assertRaises(ValidationError) as ctx:
@ -308,7 +340,7 @@ class TestRecordSvcb(TestCase):
{ {
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': {'priority': 1, 'target': 'foo.bar.baz'},
'value': {'svcpriority': 1, 'targetname': 'foo.bar.baz'},
}, },
) )
self.assertEqual( self.assertEqual(
@ -324,10 +356,10 @@ class TestRecordSvcb(TestCase):
{ {
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': {'priority': 1, 'target': ''},
'value': {'svcpriority': 1, 'targetname': ''},
}, },
) )
self.assertEqual(['missing target'], ctx.exception.reasons)
self.assertEqual(['missing targetname'], ctx.exception.reasons)
# target must be a valid FQDN # target must be a valid FQDN
with self.assertRaises(ValidationError) as ctx: with self.assertRaises(ValidationError) as ctx:
@ -337,7 +369,10 @@ class TestRecordSvcb(TestCase):
{ {
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': {'priority': 1, 'target': 'bla foo.bar.com.'},
'value': {
'svcpriority': 1,
'targetname': 'bla foo.bar.com.',
},
}, },
) )
self.assertEqual( self.assertEqual(
@ -352,7 +387,7 @@ class TestRecordSvcb(TestCase):
{ {
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': {'priority': 1, 'target': '.'},
'value': {'svcpriority': 1, 'targetname': '.'},
}, },
) )
@ -365,14 +400,14 @@ class TestRecordSvcb(TestCase):
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': { 'value': {
'priority': 0,
'target': 'foo.bar.com.',
'params': ['port=8000'],
'svcpriority': 0,
'targetname': 'foo.bar.com.',
'svcparams': ['port=8000'],
}, },
}, },
) )
self.assertEqual( self.assertEqual(
['params set on AliasMode SVCB record'], ctx.exception.reasons
['svcparams set on AliasMode SVCB record'], ctx.exception.reasons
) )
# Unknown param # Unknown param
@ -384,9 +419,9 @@ class TestRecordSvcb(TestCase):
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': { 'value': {
'priority': 1,
'target': 'foo.bar.com.',
'params': ['blablabla=222'],
'svcpriority': 1,
'targetname': 'foo.bar.com.',
'svcparams': ['blablabla=222'],
}, },
}, },
) )
@ -401,9 +436,9 @@ class TestRecordSvcb(TestCase):
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': { 'value': {
'priority': 1,
'target': 'foo.bar.com.',
'params': ['port=100000'],
'svcpriority': 1,
'targetname': 'foo.bar.com.',
'svcparams': ['port=100000'],
}, },
}, },
) )
@ -420,9 +455,9 @@ class TestRecordSvcb(TestCase):
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': { 'value': {
'priority': 1,
'target': 'foo.bar.com.',
'params': ['port=foo'],
'svcpriority': 1,
'targetname': 'foo.bar.com.',
'svcparams': ['port=foo'],
}, },
}, },
) )
@ -436,9 +471,9 @@ class TestRecordSvcb(TestCase):
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': { 'value': {
'priority': 1,
'target': 'foo.bar.com.',
'params': ['no-default-alpn'],
'svcpriority': 1,
'targetname': 'foo.bar.com.',
'svcparams': ['no-default-alpn'],
}, },
}, },
) )
@ -452,9 +487,9 @@ class TestRecordSvcb(TestCase):
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': { 'value': {
'priority': 1,
'target': 'foo.bar.com.',
'params': ['no-default-alpn=foobar'],
'svcpriority': 1,
'targetname': 'foo.bar.com.',
'svcparams': ['no-default-alpn=foobar'],
}, },
}, },
) )
@ -472,9 +507,9 @@ class TestRecordSvcb(TestCase):
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': { 'value': {
'priority': 1,
'target': 'foo.bar.com.',
'params': ['alpn=h2,😅'],
'svcpriority': 1,
'targetname': 'foo.bar.com.',
'svcparams': ['alpn=h2,😅'],
}, },
}, },
) )
@ -489,9 +524,9 @@ class TestRecordSvcb(TestCase):
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': { 'value': {
'priority': 1,
'target': 'foo.bar.com.',
'params': ['ipv4hint=192.0.2.0,500.500.30.30'],
'svcpriority': 1,
'targetname': 'foo.bar.com.',
'svcparams': ['ipv4hint=192.0.2.0,500.500.30.30'],
}, },
}, },
) )
@ -509,9 +544,9 @@ class TestRecordSvcb(TestCase):
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': { 'value': {
'priority': 1,
'target': 'foo.bar.com.',
'params': ['ipv6hint=2001:db8:43::1,notanip'],
'svcpriority': 1,
'targetname': 'foo.bar.com.',
'svcparams': ['ipv6hint=2001:db8:43::1,notanip'],
}, },
}, },
) )
@ -529,9 +564,9 @@ class TestRecordSvcb(TestCase):
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': { 'value': {
'priority': 1,
'target': 'foo.bar.com.',
'params': ['mandatory=ipv4hint,unknown,key4444'],
'svcpriority': 1,
'targetname': 'foo.bar.com.',
'svcparams': ['mandatory=ipv4hint,unknown,key4444'],
}, },
}, },
) )
@ -549,9 +584,9 @@ class TestRecordSvcb(TestCase):
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': { 'value': {
'priority': 1,
'target': 'foo.bar.com.',
'params': ['ech=dG90YWxseUZha2VFQ0hPcHRpb24'],
'svcpriority': 1,
'targetname': 'foo.bar.com.',
'svcparams': ['ech=dG90YWxseUZha2VFQ0hPcHRpb24'],
}, },
}, },
) )
@ -568,9 +603,9 @@ class TestRecordSvcb(TestCase):
'type': 'SVCB', 'type': 'SVCB',
'ttl': 600, 'ttl': 600,
'value': { 'value': {
'priority': 1,
'target': 'foo.bar.com.',
'params': [
'svcpriority': 1,
'targetname': 'foo.bar.com.',
'svcparams': [
'key100000=foo', 'key100000=foo',
'key3333=bar', 'key3333=bar',
'keyXXX=foo', 'keyXXX=foo',


Write Preview
Loading…
Cancel
Save