Browse Source

Revert "Zone._remove_record shim removed in favor of long standing Zone.remove_record"

This reverts commit 9f22173d30.
pull/956/head
Ross McFarland 3 years ago
parent
commit
25615b3196
No known key found for this signature in database GPG Key ID: 943B179E15D3B22A
3 changed files with 4 additions and 3 deletions
  1. +0
    -2
      CHANGELOG.md
  2. +3
    -0
      octodns/zone.py
  3. +1
    -1
      tests/test_octodns_zone.py

+ 0
- 2
CHANGELOG.md View File

@ -6,8 +6,6 @@
* Provider, Source, and Processor shims removed, they've been warnings for >
1yr. Everything should be using and referring to provider-specific
modules now.
* Zone._remove_record shim removed in favor of long standing
Zone.remove_record
#### Stuff


+ 3
- 0
octodns/zone.py View File

@ -132,6 +132,9 @@ class Zone(object):
self._records[record.name].discard(record)
# TODO: delete this
_remove_record = remove_record
def changes(self, desired, target):
self.log.debug('changes: zone=%s, target=%s', self, target)


+ 1
- 1
tests/test_octodns_zone.py View File

@ -125,7 +125,7 @@ class TestZone(TestCase):
# add a record, delete a record -> [Delete, Create]
c = ARecord(before, 'c', {'ttl': 42, 'value': '1.1.1.1'})
after.add_record(c)
after.remove_record(b)
after._remove_record(b)
self.assertEqual(after.records, set([a, c]))
changes = before.changes(after, target)
self.assertEqual(2, len(changes))


Loading…
Cancel
Save