Browse Source

Flip ttl and type return order

pull/930/head
Ross McFarland 3 years ago
parent
commit
2c5d8ad101
No known key found for this signature in database GPG Key ID: 943B179E15D3B22A
2 changed files with 4 additions and 4 deletions
  1. +2
    -2
      octodns/record/__init__.py
  2. +2
    -2
      tests/test_octodns_record.py

+ 2
- 2
octodns/record/__init__.py View File

@ -421,8 +421,8 @@ class ValuesMixin(object):
def rrs(self): def rrs(self):
return ( return (
self.fqdn, self.fqdn,
self._type,
self.ttl, self.ttl,
self._type,
[v.rdata_text for v in self.values], [v.rdata_text for v in self.values],
) )
@ -521,7 +521,7 @@ class ValueMixin(object):
@property @property
def rrs(self): def rrs(self):
return self.fqdn, self._type, self.ttl, [self.value.rdata_text]
return self.fqdn, self.ttl, self._type, [self.value.rdata_text]
def __repr__(self): def __repr__(self):
klass = self.__class__.__name__ klass = self.__class__.__name__


+ 2
- 2
tests/test_octodns_record.py View File

@ -2515,7 +2515,7 @@ class TestRecord(TestCase):
{'ttl': 42, 'type': 'A', 'values': ['1.2.3.4', '2.3.4.5']}, {'ttl': 42, 'type': 'A', 'values': ['1.2.3.4', '2.3.4.5']},
) )
self.assertEqual( self.assertEqual(
('a.unit.tests.', 'A', 42, ['1.2.3.4', '2.3.4.5']), record.rrs
('a.unit.tests.', 42, 'A', ['1.2.3.4', '2.3.4.5']), record.rrs
) )
record = Record.new( record = Record.new(
@ -2524,7 +2524,7 @@ class TestRecord(TestCase):
{'ttl': 43, 'type': 'CNAME', 'value': 'target.unit.tests.'}, {'ttl': 43, 'type': 'CNAME', 'value': 'target.unit.tests.'},
) )
self.assertEqual( self.assertEqual(
('cname.unit.tests.', 'CNAME', 43, ['target.unit.tests.']),
('cname.unit.tests.', 43, 'CNAME', ['target.unit.tests.']),
record.rrs, record.rrs,
) )


Loading…
Cancel
Save