Merge pull request #35 from github/dyn-monitor-user-agent

Dyn monitor user agent

octodns/provider/dyn.py

@@ -450,6 +450,7 @@ class DynProvider(BaseProvider):
             monitor = DSFMonitor(fqdn, protocol='HTTPS', response_count=2,
                                  probe_interval=60, retries=2, port=443,
                                  active='Y', host=fqdn[:-1], timeout=10,
+                                 header='User-Agent: Dyn Monitor',
                                  path='/_dns')
             self._traffic_director_monitors[fqdn] = monitor
             return monitor

tests/test_octodns_provider_dyn.py

@@ -304,7 +304,7 @@ class TestDynProvider(TestCase):
                     'fqdn': '_srv._tcp.unit.tests',
                     'rdata': {'port': 10,
                               'priority': 11,
-                              'target': u'foo-1.unit.tests.',
+                              'target': 'foo-1.unit.tests.',
                               'weight': 12},
                     'record_id': 10,
                     'record_type': 'SRV',
@@ -314,7 +314,7 @@ class TestDynProvider(TestCase):
                     'fqdn': '_srv._tcp.unit.tests',
                     'rdata': {'port': 20,
                               'priority': 21,
-                              'target': u'foo-2.unit.tests.',
+                              'target': 'foo-2.unit.tests.',
                               'weight': 22},
                     'record_id': 11,
                     'record_type': 'SRV',
@@ -385,7 +385,7 @@ class TestDynProvider(TestCase):
                     'fqdn': '_srv._tcp.unit.tests',
                     'rdata': {'port': 10,
                               'priority': 11,
-                              'target': u'foo-1.unit.tests.',
+                              'target': 'foo-1.unit.tests.',
                               'weight': 12},
                     'record_id': 5,
                     'record_type': 'SRV',
@@ -395,7 +395,7 @@ class TestDynProvider(TestCase):
                     'fqdn': '_srv._tcp.unit.tests',
                     'rdata': {'port': 20,
                               'priority': 21,
-                              'target': u'foo-2.unit.tests.',
+                              'target': 'foo-2.unit.tests.',
                               'weight': 22},
                     'record_id': 6,
                     'record_type': 'SRV',
@@ -533,7 +533,7 @@ class TestDynProviderGeo(TestCase):
             'notifier': '',
             'options': {
                 'expected': '',
-                'header': '',
+                'header': 'User-Agent: Dyn Monitor',
                 'host': 'unit.tests',
                 'path': '/_dns',
                 'port': '443',
@@ -642,30 +642,30 @@ class TestDynProviderGeo(TestCase):
         geo_monitor_id = '42x'
         mock.side_effect = [self.monitors_response, {
             'data': {
-                u'active': u'Y',
-                u'dsf_monitor_id': geo_monitor_id,
-                u'endpoints': [],
-                u'label': u'geo.unit.tests.',
-                u'notifier': u'',
-                u'options': {
-                    u'expected': u'',
-                    u'header': u'',
-                    u'host': u'geo.unit.tests.',
-                    u'path': u'/_dns',
-                    u'port': u'443',
-                    u'timeout': u'10'
+                'active': 'Y',
+                'dsf_monitor_id': geo_monitor_id,
+                'endpoints': [],
+                'label': 'geo.unit.tests.',
+                'notifier': '',
+                'options': {
+                    'expected': '',
+                    'header': 'User-Agent: Dyn Monitor',
+                    'host': 'geo.unit.tests.',
+                    'path': '/_dns',
+                    'port': '443',
+                    'timeout': '10'
                 },
-                u'probe_interval': u'60',
-                u'protocol': u'HTTPS',
-                u'response_count': u'2',
-                u'retries': u'2'
+                'probe_interval': '60',
+                'protocol': 'HTTPS',
+                'response_count': '2',
+                'retries': '2'
             },
-            u'job_id': 3376259461,
-            u'msgs': [{u'ERR_CD': None,
-                       u'INFO': u'add: Here is the new monitor',
-                       u'LVL': u'INFO',
-                       u'SOURCE': u'BLL'}],
-            u'status': u'success'
+            'job_id': 3376259461,
+            'msgs': [{'ERR_CD': None,
+                      'INFO': 'add: Here is the new monitor',
+                      'LVL': 'INFO',
+                      'SOURCE': 'BLL'}],
+            'status': 'success'
         }]
 
         # ask for a monitor that doesn't exist
@@ -676,14 +676,15 @@ class TestDynProviderGeo(TestCase):
             call('/DSFMonitor/', 'GET', {'detail': 'Y'}),
             call('/DSFMonitor/', 'POST', {
                 'retries': 2,
-                'protocol': u'HTTPS',
+                'protocol': 'HTTPS',
                 'response_count': 2,
-                'label': u'geo.unit.tests.',
+                'label': 'geo.unit.tests.',
                 'probe_interval': 60,
                 'active': 'Y',
                 'options': {
-                    'path': u'/_dns',
-                    'host': u'geo.unit.tests',
+                    'path': '/_dns',
+                    'host': 'geo.unit.tests',
+                    'header': 'User-Agent: Dyn Monitor',
                     'port': 443,
                     'timeout': 10
                 }