Remove Azure allow empty CNAME, PTR value behavior

cc #84 #628

octodns/provider/azuredns.py

@@ -416,14 +416,8 @@ class AzureProvider(BaseProvider):
             :type  azrecord: azure.mgmt.dns.models.RecordSet
 
             :type  return: dict
-
-            CNAME and PTR both use the catch block to catch possible empty
-            records. Refer to population comment.
         '''
-        try:
-            return {'value': _check_endswith_dot(azrecord.cname_record.cname)}
-        except:
-            return {'value': '.'}
+        return {'value': _check_endswith_dot(azrecord.cname_record.cname)}
 
     def _data_for_MX(self, azrecord):
         return {'values': [{'preference': ar.preference,
@@ -435,11 +429,8 @@ class AzureProvider(BaseProvider):
         return {'values': [_check_endswith_dot(val) for val in vals]}
 
     def _data_for_PTR(self, azrecord):
-        try:
-            ptrdname = azrecord.ptr_records[0].ptrdname
-            return {'value': _check_endswith_dot(ptrdname)}
-        except:
-            return {'value': '.'}
+        ptrdname = azrecord.ptr_records[0].ptrdname
+        return {'value': _check_endswith_dot(ptrdname)}
 
     def _data_for_SRV(self, azrecord):
         return {'values': [{'priority': ar.priority, 'weight': ar.weight,

tests/test_octodns_provider_azuredns.py

@@ -389,9 +389,6 @@ class TestAzureDnsProvider(TestCase):
         recordSet = RecordSet(cname_record=cname1)
         recordSet.name, recordSet.ttl, recordSet.type = 'cname1', 5, 'CNAME'
         rs.append(recordSet)
-        recordSet = RecordSet(cname_record=None)
-        recordSet.name, recordSet.ttl, recordSet.type = 'cname2', 6, 'CNAME'
-        rs.append(recordSet)
         recordSet = RecordSet(mx_records=[MxRecord(preference=10,
                                                    exchange='mx1.unit.test.')])
         recordSet.name, recordSet.ttl, recordSet.type = 'mx1', 7, 'MX'
@@ -413,9 +410,6 @@ class TestAzureDnsProvider(TestCase):
         recordSet = RecordSet(ptr_records=[ptr1])
         recordSet.name, recordSet.ttl, recordSet.type = 'ptr1', 11, 'PTR'
         rs.append(recordSet)
-        recordSet = RecordSet(ptr_records=[PtrRecord(ptrdname=None)])
-        recordSet.name, recordSet.ttl, recordSet.type = 'ptr2', 12, 'PTR'
-        rs.append(recordSet)
         recordSet = RecordSet(srv_records=[SrvRecord(priority=1,
                                                      weight=2,
                                                      port=3,
@@ -449,7 +443,7 @@ class TestAzureDnsProvider(TestCase):
         exists = provider.populate(zone)
         self.assertTrue(exists)
 
-        self.assertEquals(len(zone.records), 18)
+        self.assertEquals(len(zone.records), 16)
 
     def test_populate_zone(self):
         provider = self._get_provider()