From e6cb0fb06aef2286549b3238fb21aefce5b9255d Mon Sep 17 00:00:00 2001 From: Ivan Schaller Date: Sun, 6 Jul 2025 19:15:41 +0200 Subject: [PATCH 1/3] add missing kwargs to make include_target work Signed-off-by: Ivan Schaller --- octodns/processor/filter.py | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/octodns/processor/filter.py b/octodns/processor/filter.py index 638823d..5795234 100644 --- a/octodns/processor/filter.py +++ b/octodns/processor/filter.py @@ -175,8 +175,8 @@ class NameAllowlistFilter(_NameBaseFilter, AllowsMixin): - route53 ''' - def __init__(self, name, allowlist): - super().__init__(name, allowlist) + def __init__(self, name, allowlist, **kwargs): + super().__init__(name, allowlist, **kwargs) class NameRejectlistFilter(_NameBaseFilter, RejectsMixin): @@ -211,8 +211,8 @@ class NameRejectlistFilter(_NameBaseFilter, RejectsMixin): - route53 ''' - def __init__(self, name, rejectlist): - super().__init__(name, rejectlist) + def __init__(self, name, rejectlist, **kwargs): + super().__init__(name, rejectlist, **kwargs) class _ValueBaseFilter(_FilterProcessor): @@ -284,9 +284,9 @@ class ValueAllowlistFilter(_ValueBaseFilter, AllowsMixin): - route53 ''' - def __init__(self, name, allowlist): + def __init__(self, name, allowlist, **kwargs): self.log = getLogger(f'ValueAllowlistFilter[{name}]') - super().__init__(name, allowlist) + super().__init__(name, allowlist, **kwargs) class ValueRejectlistFilter(_ValueBaseFilter, RejectsMixin): @@ -321,9 +321,9 @@ class ValueRejectlistFilter(_ValueBaseFilter, RejectsMixin): - route53 ''' - def __init__(self, name, rejectlist): + def __init__(self, name, rejectlist, **kwargs): self.log = getLogger(f'ValueRejectlistFilter[{name}]') - super().__init__(name, rejectlist) + super().__init__(name, rejectlist, **kwargs) class _NetworkValueBaseFilter(BaseProcessor): @@ -500,6 +500,7 @@ class ZoneNameFilter(_FilterProcessor): # If true a ValidationError will be throw when such records are # encouterd, if false the records will just be ignored/omitted. # (default: true) + # error: True # Optional param that can be set to False to leave the target zone # alone, thus allowing deletion of existing records # (default: true) From 96ec4106ee47667d471928943f22832e7560f032 Mon Sep 17 00:00:00 2001 From: Ivan Schaller Date: Sun, 6 Jul 2025 19:22:59 +0200 Subject: [PATCH 2/3] add changelog Signed-off-by: Ivan Schaller --- .changelog/4f9d1e4e41834834a21cd99ef46af928.md | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 .changelog/4f9d1e4e41834834a21cd99ef46af928.md diff --git a/.changelog/4f9d1e4e41834834a21cd99ef46af928.md b/.changelog/4f9d1e4e41834834a21cd99ef46af928.md new file mode 100644 index 0000000..34b51a3 --- /dev/null +++ b/.changelog/4f9d1e4e41834834a21cd99ef46af928.md @@ -0,0 +1,4 @@ +--- +type: none +--- +fix include-target in filter processors \ No newline at end of file From 1ef183655a8f180b17cb3efa0007485af6680394 Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Sun, 6 Jul 2025 12:05:46 -0700 Subject: [PATCH 3/3] bump filter processor kwargs changelog to minor and update msg --- .changelog/4f9d1e4e41834834a21cd99ef46af928.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.changelog/4f9d1e4e41834834a21cd99ef46af928.md b/.changelog/4f9d1e4e41834834a21cd99ef46af928.md index 34b51a3..9833c0a 100644 --- a/.changelog/4f9d1e4e41834834a21cd99ef46af928.md +++ b/.changelog/4f9d1e4e41834834a21cd99ef46af928.md @@ -1,4 +1,4 @@ --- -type: none +type: minor --- -fix include-target in filter processors \ No newline at end of file +Add kwags to filter processors __init__