From 55af09d73cf512b00a03c58786a4f16971e8e915 Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Thu, 18 Feb 2021 07:11:18 -0800 Subject: [PATCH] use super for supports base case, remove unused `data_for`. --- octodns/provider/dnsimple.py | 3 +-- octodns/provider/dnsmadeeasy.py | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/octodns/provider/dnsimple.py b/octodns/provider/dnsimple.py index 647b89c..599eacb 100644 --- a/octodns/provider/dnsimple.py +++ b/octodns/provider/dnsimple.py @@ -280,7 +280,6 @@ class DnsimpleProvider(BaseProvider): values = defaultdict(lambda: defaultdict(list)) for record in self.zone_records(zone): _type = record['type'] - data_for = getattr(self, '_data_for_{}'.format(_type), None) if _type not in self.SUPPORTS: self.log.warning( 'populate: skipping unsupported %s record', @@ -325,7 +324,7 @@ class DnsimpleProvider(BaseProvider): ) return False - return record._type in self.SUPPORTS + return super(DnsimpleProvider, self).supports(record) def _params_for_multiple(self, record): for value in record.values: diff --git a/octodns/provider/dnsmadeeasy.py b/octodns/provider/dnsmadeeasy.py index 7880280..b222b5c 100644 --- a/octodns/provider/dnsmadeeasy.py +++ b/octodns/provider/dnsmadeeasy.py @@ -306,7 +306,7 @@ class DnsMadeEasyProvider(BaseProvider): ) return False - return record._type in self.SUPPORTS + return super(DnsMadeEasyProvider, self).supports(record) def _params_for_multiple(self, record): for value in record.values: