From 77bf6ced181b1e277761ad2ff38301230dad57a6 Mon Sep 17 00:00:00 2001
From: Ross McFarland <rwmcfa1@gmail.com>
Date: Wed, 23 Oct 2024 13:52:25 -0700
Subject: [PATCH] Deprecate two legacy param/api fallbacks

---
 CHANGELOG.md       |  4 ++++
 octodns/manager.py | 11 ++++++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 665db90..93a51ed 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,9 @@
 ## v1.?.? - 2024-??-?? - ???
 
+* Deprecation warning for Source.populate w/o the lenient param, to be removed
+  in 2.x
+* Deprecation warning for Provider.populate w/o the processors param, to be
+  removed in 2.x
 * Add YamlProvider.order_mode to allow picking between natural (human)
   the default when enforce_order=True and simple `sort`.
 
diff --git a/octodns/manager.py b/octodns/manager.py
index c4f6358..eb2b772 100644
--- a/octodns/manager.py
+++ b/octodns/manager.py
@@ -13,6 +13,7 @@ from logging import getLogger
 from sys import stdout
 
 from . import __version__
+from .deprecation import deprecated
 from .idna import IdnaDict, idna_decode, idna_encode
 from .processor.arpa import AutoArpa
 from .processor.meta import MetaProcessor
@@ -509,6 +510,10 @@ class Manager(object):
                 except TypeError as e:
                     if "unexpected keyword argument 'lenient'" not in str(e):
                         raise
+                    deprecated(
+                        f'`populate` method does not support the `lenient` param, fallback is DEPRECATED. Will be removed in 2.0. Class {source.__class__.__name__}',
+                        stacklevel=99,
+                    )
                     self.log.warning(
                         'provider %s does not accept lenient param',
                         source.__class__.__name__,
@@ -527,6 +532,10 @@ class Manager(object):
             except TypeError as e:
                 if "keyword argument 'processors'" not in str(e):
                     raise
+                deprecated(
+                    f'`plan` method does not support the `processors` param, fallback is DEPRECATED. Will be removed in 2.0. Class {target.__class__.__name__}',
+                    stacklevel=99,
+                )
                 self.log.warning(
                     'provider.plan %s does not accept processors param',
                     target.__class__.__name__,
@@ -568,7 +577,7 @@ class Manager(object):
             sources = collected
         except KeyError:
             raise ManagerException(
-                f'Zone {decoded_zone_name}, unknown ' f'source: {source}'
+                f'Zone {decoded_zone_name}, unknown source: {source}'
             )
 
         return sources