Browse Source

make logging consistent

pull/128/head
Tim Hughes 8 years ago
parent
commit
78ef267ab5
2 changed files with 7 additions and 2 deletions
  1. +2
    -1
      octodns/provider/dyn.py
  2. +5
    -1
      tests/test_octodns_provider_dyn.py

+ 2
- 1
octodns/provider/dyn.py View File

@ -291,7 +291,8 @@ class DynProvider(BaseProvider):
try:
fqdn, _type = td.label.split(':', 1)
except ValueError as e:
self.log.warn("Failed to load TraficDirector '{}': {}".format(td.label, e))
self.log.warn("Failed to load TrafficDirector %s: %s",
td.label, e.message)
continue
tds[fqdn][_type] = td
self._traffic_directors = dict(tds)


+ 5
- 1
tests/test_octodns_provider_dyn.py View File

@ -650,7 +650,11 @@ class TestDynProviderGeo(TestCase):
set(tds.keys()))
self.assertEquals(['A'], tds['unit.tests.'].keys())
self.assertEquals(['A'], tds['geo.unit.tests.'].keys())
provider.log.warn.assert_called_with("Failed to load TraficDirector 'something else': need more than 1 value to unpack")
provider.log.warn.assert_called_with(
u'Failed to load TrafficDirector %s: %s',
u'something else',
'need more than 1 value to unpack'
)
@patch('dyn.core.SessionEngine.execute')


Loading…
Cancel
Save