From 8c1fe707e8493230835fffbb02088b1b6cd6b48d Mon Sep 17 00:00:00 2001 From: Michael McAllister Date: Sun, 4 Mar 2018 18:02:51 +1100 Subject: [PATCH] ISSUE #26 Skip Alias recordset for Route53 Provider --- octodns/provider/route53.py | 6 ++++++ tests/test_octodns_provider_route53.py | 8 ++++++++ 2 files changed, 14 insertions(+) diff --git a/octodns/provider/route53.py b/octodns/provider/route53.py index 3333f4e..d206320 100644 --- a/octodns/provider/route53.py +++ b/octodns/provider/route53.py @@ -463,6 +463,12 @@ class Route53Provider(BaseProvider): record_type = rrset['Type'] if record_type == 'SOA': continue + if 'AliasTarget' in rrset: + # Alias records are Route53 specific and are not + # portable, so we need to skip them + self.log.warning("%s is an Alias record. Skipping..." + % rrset['Name']) + continue data = getattr(self, '_data_for_{}'.format(record_type))(rrset) records[record_name][record_type].append(data) diff --git a/tests/test_octodns_provider_route53.py b/tests/test_octodns_provider_route53.py index 3839a16..f4fc99f 100644 --- a/tests/test_octodns_provider_route53.py +++ b/tests/test_octodns_provider_route53.py @@ -313,6 +313,14 @@ class TestRoute53Provider(TestCase): 'Value': '0 issue "ca.unit.tests"', }], 'TTL': 69, + }, { + 'AliasTarget': { + 'HostedZoneId': 'Z119WBBTVP5WFX', + 'EvaluateTargetHealth': False, + 'DNSName': 'unit.tests.' + }, + 'Type': 'A', + 'Name': 'alias.unit.tests.' }], 'IsTruncated': False, 'MaxItems': '100',