Browse Source

Apply suggestions/corrections from a round of code review

pull/876/head
Ross McFarland 4 years ago
committed by GitHub
parent
commit
8e70695eb2
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 7 deletions
  1. +1
    -4
      CHANGELOG.md
  2. +3
    -3
      octodns/provider/plan.py

+ 1
- 4
CHANGELOG.md View File

@ -5,16 +5,13 @@
* Foundational support for root NS record management. * Foundational support for root NS record management.
* YamlProvider has it enabled and in general everyone should add root NS * YamlProvider has it enabled and in general everyone should add root NS
records that match what is in their provider(s) as of this release if they records that match what is in their provider(s) as of this release if they
an're already there.
aren't already there.
* Note that if you created you config files with `octodns-dump` the records * Note that if you created you config files with `octodns-dump` the records
are likely already there and match what was configured at the time of the are likely already there and match what was configured at the time of the
dump. dump.
* Other providers will add root NS support over time once they have had the * Other providers will add root NS support over time once they have had the
chance to investigate the functionality and implement management if chance to investigate the functionality and implement management if
possible with whatever accomidations are required. possible with whatever accomidations are required.
* Once you are using this release and an provider version that supports root
NS management you will get errors if you do not have root NS records
included by your source(s).
* Watch your providers README.md and CHANGELOG.md for support and more * Watch your providers README.md and CHANGELOG.md for support and more
information. information.


+ 3
- 3
octodns/provider/plan.py View File

@ -99,9 +99,9 @@ class Plan(object):
# If we have any changes of the root NS record for the zone it's a huge # If we have any changes of the root NS record for the zone it's a huge
# deal and force should always be required for extra care # deal and force should always be required for extra care
if self.exists and [True for c in self.changes
if c.record and c.record._type == 'NS' and
c.record.name == '']:
if self.exists and any(c for c in self.changes
if c.record and c.record._type == 'NS' and
c.record.name == ''):
raise RootNsChange() raise RootNsChange()
def __repr__(self): def __repr__(self):


Loading…
Cancel
Save