Merge pull request #299 from github/dnsimple-txt-semicolons

Fixes for DNSimple's TXT ; handling

octodns/provider/dnsimple.py

@@ -112,7 +112,14 @@ class DnsimpleProvider(BaseProvider):
     _data_for_A = _data_for_multiple
     _data_for_AAAA = _data_for_multiple
     _data_for_SPF = _data_for_multiple
-    _data_for_TXT = _data_for_multiple
+
+    def _data_for_TXT(self, _type, records):
+        return {
+            'ttl': records[0]['ttl'],
+            'type': _type,
+            # escape semicolons
+            'values': [r['content'].replace(';', '\\;') for r in records]
+        }
 
     def _data_for_CAA(self, _type, records):
         values = []
@@ -290,7 +297,16 @@ class DnsimpleProvider(BaseProvider):
     _params_for_AAAA = _params_for_multiple
     _params_for_NS = _params_for_multiple
     _params_for_SPF = _params_for_multiple
-    _params_for_TXT = _params_for_multiple
+
+    def _params_for_TXT(self, record):
+        for value in record.values:
+            yield {
+                # un-escape semicolons
+                'content': value.replace('\\', ''),
+                'name': record.name,
+                'ttl': record.ttl,
+                'type': record._type,
+            }
 
     def _params_for_CAA(self, record):
         for value in record.values:

tests/fixtures/dnsimple-page-2.json

@@ -133,7 +133,7 @@
       "zone_id": "unit.tests",
       "parent_id": null,
       "name": "txt",
-      "content": "v=DKIM1\\;k=rsa\\;s=email\\;h=sha256\\;p=A/kinda+of/long/string+with+numb3rs",
+      "content": "v=DKIM1;k=rsa;s=email;h=sha256;p=A/kinda+of/long/string+with+numb3rs",
       "ttl": 600,
       "priority": null,
       "type": "TXT",