diff --git a/octodns/manager.py b/octodns/manager.py index df64b2e..b8fb0ff 100644 --- a/octodns/manager.py +++ b/octodns/manager.py @@ -475,7 +475,6 @@ class Manager(object): force=False, plan_output_fh=stdout, ): - self.log.info( 'sync: eligible_zones=%s, eligible_targets=%s, dry_run=%s, ' 'force=%s, plan_output_fh=%s', diff --git a/octodns/provider/plan.py b/octodns/provider/plan.py index bdd47a4..e27b1e3 100644 --- a/octodns/provider/plan.py +++ b/octodns/provider/plan.py @@ -78,7 +78,6 @@ class Plan(object): self.existing and len(self.existing.records) >= self.MIN_EXISTING_RECORDS ): - existing_record_count = len(self.existing.records) if existing_record_count > 0: update_pcent = ( diff --git a/octodns/source/base.py b/octodns/source/base.py index 1c3ff15..0f0b2dd 100644 --- a/octodns/source/base.py +++ b/octodns/source/base.py @@ -4,7 +4,6 @@ class BaseSource(object): - SUPPORTS_MULTIVALUE_PTR = False SUPPORTS_POOL_VALUE_STATUS = False SUPPORTS_ROOT_NS = False diff --git a/tests/test_octodns_processor_arpa.py b/tests/test_octodns_processor_arpa.py index b3baa43..b2038b1 100644 --- a/tests/test_octodns_processor_arpa.py +++ b/tests/test_octodns_processor_arpa.py @@ -11,7 +11,6 @@ from octodns.zone import Zone class TestAutoArpa(TestCase): def test_empty_zone(self): - # empty zone no records zone = Zone('unit.tests.', []) aa = AutoArpa('auto-arpa') diff --git a/tests/test_octodns_record_ip.py b/tests/test_octodns_record_ip.py index 29d576f..f9ba62d 100644 --- a/tests/test_octodns_record_ip.py +++ b/tests/test_octodns_record_ip.py @@ -10,7 +10,6 @@ from octodns.zone import Zone class TestRecordIp(TestCase): def test_ipv4_value_rdata_text(self): - # anything goes, we're a noop for s in ( None, diff --git a/tests/test_octodns_record_mx.py b/tests/test_octodns_record_mx.py index d3da73d..1ae37e6 100644 --- a/tests/test_octodns_record_mx.py +++ b/tests/test_octodns_record_mx.py @@ -68,7 +68,6 @@ class TestRecordMx(TestCase): a.__repr__() def test_mx_value_rdata_text(self): - # empty string won't parse with self.assertRaises(RrParseError): MxValue.parse_rdata_text('') diff --git a/tests/test_octodns_record_ptr.py b/tests/test_octodns_record_ptr.py index 14f744c..7a380e6 100644 --- a/tests/test_octodns_record_ptr.py +++ b/tests/test_octodns_record_ptr.py @@ -63,7 +63,6 @@ class TestRecordPtr(TestCase): ) def test_ptr_rdata_text(self): - # anything goes, we're a noop for s in ( None, diff --git a/tests/test_octodns_record_srv.py b/tests/test_octodns_record_srv.py index f86d406..3cc39b5 100644 --- a/tests/test_octodns_record_srv.py +++ b/tests/test_octodns_record_srv.py @@ -81,7 +81,6 @@ class TestRecordSrv(TestCase): a.__repr__() def test_srv_value_rdata_text(self): - # empty string won't parse with self.assertRaises(RrParseError): SrvValue.parse_rdata_text('') diff --git a/tests/test_octodns_record_sshfp.py b/tests/test_octodns_record_sshfp.py index f026514..251efca 100644 --- a/tests/test_octodns_record_sshfp.py +++ b/tests/test_octodns_record_sshfp.py @@ -85,7 +85,6 @@ class TestRecordSshfp(TestCase): a.__repr__() def test_sshfp_value_rdata_text(self): - # empty string won't parse with self.assertRaises(RrParseError): SshfpValue.parse_rdata_text('') diff --git a/tests/test_octodns_record_target.py b/tests/test_octodns_record_target.py index 728c349..715cd4a 100644 --- a/tests/test_octodns_record_target.py +++ b/tests/test_octodns_record_target.py @@ -11,7 +11,6 @@ from octodns.zone import Zone class TestRecordTarget(TestCase): def test_target_rdata_text(self): - # anything goes, we're a noop for s in ( None, diff --git a/tests/test_octodns_record_tlsa.py b/tests/test_octodns_record_tlsa.py index 6554bbc..9739017 100644 --- a/tests/test_octodns_record_tlsa.py +++ b/tests/test_octodns_record_tlsa.py @@ -118,7 +118,6 @@ class TestRecordTlsa(TestCase): a.__repr__() def test_tsla_value_rdata_text(self): - # empty string won't parse with self.assertRaises(RrParseError): TlsaValue.parse_rdata_text('') diff --git a/tests/test_octodns_source_tinydns.py b/tests/test_octodns_source_tinydns.py index 717d46b..40ce9f5 100644 --- a/tests/test_octodns_source_tinydns.py +++ b/tests/test_octodns_source_tinydns.py @@ -150,7 +150,6 @@ class TestTinyDnsFileSource(TestCase): self.assertEqual([], changes) def test_populate_in_addr_arpa(self): - got = Zone('3.2.10.in-addr.arpa.', []) self.source.populate(got) diff --git a/tests/test_octodns_zone.py b/tests/test_octodns_zone.py index 07e94ea..0ee01b0 100644 --- a/tests/test_octodns_zone.py +++ b/tests/test_octodns_zone.py @@ -192,7 +192,6 @@ class TestZone(TestCase): self.assertTrue('whitespace not allowed' in str(ctx.exception)) def test_sub_zones(self): - # NS for exactly the sub is allowed zone = Zone('unit.tests.', set(['sub', 'barred'])) record = Record.new(