Browse Source

Remove hacky _LogLevelSetter and just setLevel on Plan logger

pull/945/head
Ross McFarland 3 years ago
parent
commit
a1e54c2bbf
No known key found for this signature in database GPG Key ID: 943B179E15D3B22A
2 changed files with 5 additions and 15 deletions
  1. +4
    -0
      octodns/cmds/args.py
  2. +1
    -15
      octodns/provider/plan.py

+ 4
- 0
octodns/cmds/args.py View File

@ -84,7 +84,11 @@ class ArgumentParser(_Base):
logger.level = DEBUG
elif args.quiet:
logger.level = WARNING
# we still want plans to come out during quite so set the plan
# logger output to info in case the PlanLogger is being used
getLogger('Plan').setLevel(INFO)
# TODO: these should move out of octoDNS core...
# boto is noisy, set it to warn
getLogger('botocore').level = WARNING
# DynectSession is noisy too


+ 1
- 15
octodns/provider/plan.py View File

@ -134,19 +134,6 @@ class _PlanOutput(object):
self.name = name
class _LogLevelSetter:
def __init__(self, logger, level):
self.logger = getLogger()
self.level = level
def __enter__(self, *args, **kwargs):
self.original_level = self.logger.level
self.logger.setLevel(self.level)
def __exit__(self, *args, **kwargs):
self.logger.setLevel(self.original_level)
class PlanLogger(_PlanOutput):
def __init__(self, name, level='info'):
super().__init__(name)
@ -203,8 +190,7 @@ class PlanLogger(_PlanOutput):
buf.write(hr)
buf.write('\n')
with _LogLevelSetter(log, INFO):
log.log(self.level, buf.getvalue())
log.log(self.level, buf.getvalue())
def _value_stringifier(record, sep):


Loading…
Cancel
Save