From 1b1590011c518441c59b537a5a086f0b367e07c2 Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Sun, 4 Jun 2017 14:07:12 -0700 Subject: [PATCH 1/3] NS1 does not support SSHFP --- octodns/provider/ns1.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/octodns/provider/ns1.py b/octodns/provider/ns1.py index 69e8da7..8e1c7fc 100644 --- a/octodns/provider/ns1.py +++ b/octodns/provider/ns1.py @@ -30,6 +30,9 @@ class Ns1Provider(BaseProvider): super(Ns1Provider, self).__init__(id, *args, **kwargs) self._client = NSONE(apiKey=api_key) + def supports(self, record): + return record._type != 'SSHFP' + def _data_for_A(self, _type, record): return { 'ttl': record['ttl'], From 23d0efdba23c89f9d4942a9998743db1337f4a2a Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Sun, 4 Jun 2017 14:08:04 -0700 Subject: [PATCH 2/3] DNSimple mock calls allowed in any order --- tests/test_octodns_provider_dnsimple.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_octodns_provider_dnsimple.py b/tests/test_octodns_provider_dnsimple.py index 48c1f6a..ace7376 100644 --- a/tests/test_octodns_provider_dnsimple.py +++ b/tests/test_octodns_provider_dnsimple.py @@ -199,4 +199,4 @@ class TestDnsimpleProvider(TestCase): call('DELETE', '/zones/unit.tests/records/11189899'), call('DELETE', '/zones/unit.tests/records/11189897'), call('DELETE', '/zones/unit.tests/records/11189898') - ]) + ], any_order=True) From 6fd7371e2f0842f97b23f5d801a55f64740ca239 Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Sun, 4 Jun 2017 14:12:53 -0700 Subject: [PATCH 3/3] DnsimpleProvider updates delete before create, or else errors thrown --- octodns/provider/dnsimple.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/octodns/provider/dnsimple.py b/octodns/provider/dnsimple.py index 7ed4fe7..407e0b9 100644 --- a/octodns/provider/dnsimple.py +++ b/octodns/provider/dnsimple.py @@ -327,8 +327,8 @@ class DnsimpleProvider(BaseProvider): self._client.record_create(new.zone.name[:-1], params) def _apply_Update(self, change): - self._apply_Create(change) self._apply_Delete(change) + self._apply_Create(change) def _apply_Delete(self, change): existing = change.existing