From ad04cefd886cca96242da4bab79771ea5c09254a Mon Sep 17 00:00:00 2001
From: Ross McFarland <ross@github.com>
Date: Wed, 19 Dec 2018 10:56:03 -0800
Subject: [PATCH] More robust __eq__ on _Dynamic objects

---
 octodns/record/__init__.py   |  6 ++++++
 tests/test_octodns_record.py | 42 +++++++++++++++++++++++++++++++++++-
 2 files changed, 47 insertions(+), 1 deletion(-)

diff --git a/octodns/record/__init__.py b/octodns/record/__init__.py
index 3bba21e..3cf4bd1 100644
--- a/octodns/record/__init__.py
+++ b/octodns/record/__init__.py
@@ -404,6 +404,8 @@ class _DynamicPool(object):
         return self.data
 
     def __eq__(self, other):
+        if not isinstance(other, _DynamicPool):
+            return False
         return self.data == other.data
 
     def __ne__(self, other):
@@ -432,6 +434,8 @@ class _DynamicRule(object):
         return self.data
 
     def __eq__(self, other):
+        if not isinstance(other, _DynamicRule):
+            return False
         return self.data == other.data
 
     def __ne__(self, other):
@@ -460,6 +464,8 @@ class _Dynamic(object):
         }
 
     def __eq__(self, other):
+        if not isinstance(other, _Dynamic):
+            return False
         ret = self.pools == other.pools and self.rules == other.rules
         return ret
 
diff --git a/tests/test_octodns_record.py b/tests/test_octodns_record.py
index 55e3be3..9a14482 100644
--- a/tests/test_octodns_record.py
+++ b/tests/test_octodns_record.py
@@ -10,7 +10,7 @@ from unittest import TestCase
 from octodns.record import ARecord, AaaaRecord, AliasRecord, CaaRecord, \
     CnameRecord, Create, Delete, GeoValue, MxRecord, NaptrRecord, \
     NaptrValue, NsRecord, Record, SshfpRecord, SpfRecord, SrvRecord, \
-    TxtRecord, Update, ValidationError
+    TxtRecord, Update, ValidationError, _Dynamic, _DynamicPool, _DynamicRule
 from octodns.zone import Zone
 
 from helpers import DynamicProvider, GeoProvider, SimpleProvider
@@ -3195,3 +3195,43 @@ class TestDynamicRecords(TestCase):
         self.assertEquals(a.dynamic.rules, a.dynamic.rules)
         self.assertEquals(a.dynamic.rules[0], a.dynamic.rules[0])
         self.assertNotEquals(a.dynamic.rules[0], c.dynamic.rules[0])
+
+    def test_dynamic_eqs(self):
+
+        pool_one = _DynamicPool('one', {
+            'values': [{
+                'value': '1.2.3.4',
+            }],
+        })
+        pool_two = _DynamicPool('two', {
+            'values': [{
+                'value': '1.2.3.5',
+            }],
+        })
+        self.assertEquals(pool_one, pool_one)
+        self.assertNotEquals(pool_one, pool_two)
+        self.assertNotEquals(pool_one, 42)
+
+        pools = {
+            'one': pool_one,
+            'two': pool_two,
+        }
+        rule_one = _DynamicRule(0, {
+            'pool': 'one',
+        })
+        rule_two = _DynamicRule(1, {
+            'pool': 'two',
+        })
+        self.assertEquals(rule_one, rule_one)
+        self.assertNotEquals(rule_one, rule_two)
+        self.assertNotEquals(rule_one, 42)
+        rules = [
+            rule_one,
+            rule_two,
+        ]
+
+        dynamic = _Dynamic(pools, rules)
+        other = _Dynamic({}, [])
+        self.assertEquals(dynamic, dynamic)
+        self.assertNotEquals(dynamic, other)
+        self.assertNotEquals(dynamic, 42)